Respect content type negotiation #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the following rules to determine the response data type 1. Use options.dataType if present 2. Try to parse from the response content type header 3. Try to parse from the request accept header Previously, only the first accept header MIME type was taken into account.
| data = xhr.responseXML; | ||
| break; | ||
| case 'json': | ||
| if (xhr.responseText !== '') { |
There was a problem hiding this comment.
What's this line for? I think invalid JSON should throw, so the dev can fix it.
There was a problem hiding this comment.
I copied this check from https://github.com/akre54/Backbone.NativeAjax/blob/master/backbone.nativeajax.js#L26. I don't know what it's for.
|
Can you look into the test failures and add some tests? This looks great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the following rules to determine the response data type
options.dataTypeif presentPreviously, only the first accept header MIME type was taken into account.
fixes #10