-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More view hook changes #3
Comments
I like where it's going and i'd like to address some of these items. Thanks for sharing. Just a few thoughts/question.
If i have the time, i 'll give it a shot next week, starting probably by Layout. In that case, do you prefer PRs on the same branch, or do you like to keep them separated of your initial PR? |
I'm of the opinion let's use natives where pollyfills are easily and readily available, and not worry too much about oldIE. We could also use a RegExp on There will be b/c breakage here. It'd be nice to limit is as much as possible, but method signatures are a fine change imo. |
I've had this sitting in my queue for a while, haven't had time to fully work out all the bugs. Here's a work-in-progress edit to the bb-view-hooks branch.
@Florian-R
The text was updated successfully, but these errors were encountered: