Skip to content

Commit 6a2ab79

Browse files
chrislaughlinakstuhl
authored andcommitted
Enable getter-return rule as a warning (facebook#3723)
* Updating ESlint to ^4.15.0 and adding new rules to config * remoning style rule and auto fixing breakages from new rules * Removing implicit-arrow-linebreak style rule * adding new rule to eslint config project * updating react scripts eslint version * Pinning version. * Changing getter-return to warn * Update package.json * Update .eslintrc
1 parent 33ae2b9 commit 6a2ab79

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

packages/eslint-config-react-app/index.js

+1
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,7 @@ module.exports = {
238238
'Please use import() instead. More info: https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#code-splitting',
239239
},
240240
],
241+
'getter-return': 'warn',
241242

242243
// https://github.com/benmosher/eslint-plugin-import/tree/master/docs/rules
243244
'import/first': 'error',

packages/react-scripts/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
"chalk": "1.1.3",
3434
"css-loader": "0.28.7",
3535
"dotenv": "4.0.0",
36-
"dotenv-expand": "4.2.0",
37-
"eslint": "4.10.0",
36+
"dotenv-expand": "4.0.1",
37+
"eslint": "4.15.0",
3838
"eslint-config-react-app": "^2.1.0",
3939
"eslint-loader": "1.9.0",
4040
"eslint-plugin-flowtype": "2.39.1",

0 commit comments

Comments
 (0)