Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): disable layout scrolling #1012

Merged
merged 6 commits into from
Nov 29, 2018
Merged

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Nov 22, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #992

@Tibing Tibing requested review from nnixaa and yggg and removed request for nnixaa November 22, 2018 15:02
@nnixaa
Copy link
Collaborator

nnixaa commented Nov 22, 2018

and check the CI, now we can trust it :)

@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #1012 into master will increase coverage by 0.14%.
The diff coverage is 96.87%.

@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
+ Coverage   76.93%   77.08%   +0.14%     
==========================================
  Files         200      200              
  Lines        6004     6030      +26     
  Branches      456      457       +1     
==========================================
+ Hits         4619     4648      +29     
+ Misses       1277     1274       -3     
  Partials      108      108
Impacted Files Coverage Δ
src/framework/theme/services/scroll.service.ts 100% <100%> (ø) ⬆️
...ork/theme/components/cdk/adapter/adapter.module.ts 100% <100%> (ø) ⬆️
...nents/cdk/adapter/block-scroll-strategy-adapter.ts 100% <100%> (ø) ⬆️
...mework/theme/components/layout/layout.component.ts 77.05% <75%> (-0.05%) ⬇️
...e/components/cdk/adapter/viewport-ruler-adapter.ts 100% <0%> (+19.04%) ⬆️

@nnixaa nnixaa merged commit 1bd8214 into akveo:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select does not hide on scrolling
4 participants