Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toastr): return toast ref #1058

Merged
merged 2 commits into from
Dec 14, 2018
Merged

feat(toastr): return toast ref #1058

merged 2 commits into from
Dec 14, 2018

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Dec 7, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1008

@Tibing Tibing requested review from nnixaa and yggg December 7, 2018 10:50
@Tibing Tibing changed the title refactor(toastr): show method return toast reference feat(toastr): return toast ref Dec 7, 2018
@nnixaa
Copy link
Collaborator

nnixaa commented Dec 7, 2018

Let's merge once we release 3.0.1

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #1058 into master will decrease coverage by 0.03%.
The diff coverage is 68.42%.

@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
- Coverage   76.68%   76.64%   -0.04%     
==========================================
  Files         200      200              
  Lines        6052     6059       +7     
  Branches      463      463              
==========================================
+ Hits         4641     4644       +3     
- Misses       1302     1306       +4     
  Partials      109      109
Impacted Files Coverage Δ
...ramework/theme/components/toastr/toastr.service.ts 70.32% <68.42%> (-2.29%) ⬇️
...rc/framework/theme/components/menu/menu.service.ts 32.84% <0%> (ø) ⬆️

@nnixaa nnixaa merged commit aeeedf1 into akveo:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow hiding toastr via public method
2 participants