Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): prevent dom api calls on server #1107

Merged
merged 1 commit into from
Dec 26, 2018
Merged

fix(layout): prevent dom api calls on server #1107

merged 1 commit into from
Dec 26, 2018

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Dec 22, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes #1060

@codecov
Copy link

codecov bot commented Dec 22, 2018

Codecov Report

Merging #1107 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1107      +/-   ##
=========================================
- Coverage   76.63%   76.6%   -0.03%     
=========================================
  Files         200     200              
  Lines        6060    6062       +2     
  Branches      464     465       +1     
=========================================
  Hits         4644    4644              
- Misses       1307    1308       +1     
- Partials      109     110       +1
Impacted Files Coverage Δ
...mework/theme/components/layout/layout.component.ts 76.16% <0%> (-0.9%) ⬇️

@nnixaa nnixaa merged commit 7511bb0 into akveo:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR getBoundingClientRect is not a function
2 participants