Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): datepicker format not available error #1117

Merged
merged 1 commit into from
Dec 30, 2018

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Dec 29, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1088

@Tibing Tibing requested a review from nnixaa December 29, 2018 16:34
@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #1117 into master will decrease coverage by 0.02%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   76.64%   76.62%   -0.03%     
==========================================
  Files         200      200              
  Lines        6068     6074       +6     
  Branches      469      469              
==========================================
+ Hits         4651     4654       +3     
- Misses       1308     1311       +3     
  Partials      109      109
Impacted Files Coverage Δ
...e/components/calendar-kit/services/date.service.ts 92.3% <ø> (ø) ⬆️
...heme/components/datepicker/datepicker.component.ts 82.78% <0%> (ø) ⬆️
...nents/calendar-kit/services/native-date.service.ts 97.05% <50%> (-1.43%) ⬇️
...c/framework/moment/services/moment-date.service.ts 92.95% <50%> (-1.25%) ⬇️
...amework/date-fns/services/date-fns-date.service.ts 76.92% <50%> (-4.9%) ⬇️

@nnixaa nnixaa merged commit 83cda23 into master Dec 30, 2018
@nnixaa nnixaa deleted the fix/datepicker-formatting-error branch December 30, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nb-datepicker with NbDateFnsModule not working
2 participants