Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/noop trigger #1133

Merged
merged 7 commits into from
Jan 8, 2019
Merged

Feat/noop trigger #1133

merged 7 commits into from
Jan 8, 2019

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Jan 8, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@nnixaa nnixaa requested a review from Tibing January 8, 2019 13:34
get mode() {
return this.trigger;
}

/**
* Describes when the container will be shown.
* Available options: click, hover and hint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a mention about noop here.

@nnixaa
Copy link
Collaborator Author

nnixaa commented Jan 8, 2019

@Tibing done

@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #1133 into master will increase coverage by 0.26%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1133      +/-   ##
==========================================
+ Coverage   77.91%   78.18%   +0.26%     
==========================================
  Files         200      200              
  Lines        6094     6096       +2     
  Branches      472      472              
==========================================
+ Hits         4748     4766      +18     
+ Misses       1235     1218      -17     
- Partials      111      112       +1
Impacted Files Coverage Δ
...work/theme/components/popover/popover.directive.ts 86.88% <ø> (ø) ⬆️
...rk/theme/components/cdk/overlay/overlay-trigger.ts 96.93% <100%> (+0.06%) ⬆️
...heme/components/datepicker/datepicker.component.ts 85.52% <0%> (+2.63%) ⬆️
.../theme/components/datepicker/datepicker-adapter.ts 67.64% <0%> (+2.94%) ⬆️
...heme/components/datepicker/datepicker.directive.ts 73.58% <0%> (+10.37%) ⬆️

@Tibing Tibing merged commit adca504 into master Jan 8, 2019
@Tibing Tibing deleted the feat/noop-trigger branch January 8, 2019 15:06
Tibing pushed a commit that referenced this pull request Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants