Dynamic popover inputs #1149
Merged
Dynamic popover inputs #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nebular into Tibing-fix/dynamic-popover-inputs
Tibing
requested changes
Jan 14, 2019
src/playground/with-layout/popover/popover-showcase.component.ts
Outdated
Show resolved
Hide resolved
src/playground/with-layout/popover/popover-showcase.component.html
Outdated
Show resolved
Hide resolved
src/framework/theme/components/cdk/overlay/dynamic/dynamic-overlay-handler.ts
Outdated
Show resolved
Hide resolved
src/framework/theme/components/cdk/overlay/dynamic/dynamic-overlay-handler.ts
Outdated
Show resolved
Hide resolved
src/framework/theme/components/cdk/overlay/dynamic/dynamic-overlay-handler.ts
Show resolved
Hide resolved
src/framework/theme/components/cdk/overlay/dynamic/dynamic-overlay-handler.ts
Show resolved
Hide resolved
src/framework/theme/components/cdk/overlay/dynamic/dynamic-overlay-handler.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1149 +/- ##
==========================================
+ Coverage 78.84% 79.54% +0.69%
==========================================
Files 200 202 +2
Lines 6070 6262 +192
Branches 469 498 +29
==========================================
+ Hits 4786 4981 +195
+ Misses 1169 1165 -4
- Partials 115 116 +1
|
|
@Tibing one more time? |
Tibing
previously approved these changes
Jan 16, 2019
|
@Tibing last time I promise 😄 |
Tibing
requested changes
Jan 23, 2019
| this._componentType, | ||
| this._content, | ||
| this._context, | ||
| this.createPositionStrategy()); |
There was a problem hiding this comment.
Please, add a new line here. it's freaking irritating 😸
| this.container.changeDetectorRef.detectChanges(); | ||
|
|
||
| /** | ||
| * Dimensions of the container may be changed after updating the content, so, we have to update |
There was a problem hiding this comment.
Let's move this comment inside this.updatePositionWhenStable() method. Because this. updatePositionWhenStable() is used in multiple places.
| } | ||
|
|
||
| protected updatePositionWhenStable() { | ||
| this.zone.onStable |
There was a problem hiding this comment.
And it still doesn't work properly.
Tibing
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves: