Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/context menu #1221

Merged
merged 5 commits into from
Feb 11, 2019
Merged

Feat/context menu #1221

merged 5 commits into from
Feb 11, 2019

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Feb 7, 2019 •
edited
Loading

Closes #1101, closes #1073

@codecov
Copy link

codecov bot commented Feb 7, 2019 •
edited
Loading

Codecov Report

Merging #1221 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
- Coverage   79.84%   79.83%   -0.02%     
==========================================
  Files         202      202              
  Lines        6246     6223      -23     
  Branches      496      492       -4     
==========================================
- Hits         4987     4968      -19     
+ Misses       1144     1141       -3     
+ Partials      115      114       -1
Impacted Files Coverage Δ
.../components/context-menu/context-menu.component.ts 100% <100%> (ø) ⬆️
.../components/context-menu/context-menu.directive.ts 89.13% <100%> (+0.39%) ⬆️
...rc/framework/theme/components/menu/menu.service.ts 48.17% <0%> (+0.72%) ⬆️

Tibing
Tibing requested changes Feb 8, 2019
View reviewed changes
src/framework/theme/components/context-menu/context-menu.directive.ts Outdated
Inject,
Input,
OnDestroy,
Input, OnChanges,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each on new line

src/framework/theme/components/context-menu/context-menu.directive.ts Outdated
NbAdjustableConnectedPositionStrategy,
NbAdjustment,
NbAdjustment, NbDynamicOverlay, NbDynamicOverlayController, NbDynamicOverlayHandler,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this row to

@nnixaa nnixaa merged commit 9f8d659 into master Feb 11, 2019
@nnixaa nnixaa deleted the feat/context-menu branch February 11, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tibing Tibing Tibing requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context Menu: dynamic inputs Context Menu: add unit tests
2 participants
@nnixaa @Tibing