-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth require valid token by default #1246
Comments
I'm using NbAuthJWTToken as wrapper class to authenticate users to /pages/** and i noticed that if i change the value of the json web token from local storage the user still authenticated even with invalid token !! below my module configuration :
|
@digitalberry-ahmed could you post an example of how you make this change to the token? |
Thank you for your responsiveness @nnixaa |
Well this is expected behavior since Nebular cannot be aware of the external changes you made outside of the Angular. |
Each auth module(login, redirect, etc.) has
requireValidToken
setting which isfalse
by default. If that setting set totrue
module will fail in cases of positive response (Http status 200) with an invalid token. Otherwise, it will signal that operation completed successfully, however it was actually failed.I propose to set
requireValidToken
totrue
by default. Because it sounds more like natural behavior for modules.The text was updated successfully, but these errors were encountered: