Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): make it valid in case of empty input #1247

Merged
merged 6 commits into from
Feb 21, 2019

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Feb 18, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1182

@Tibing Tibing requested a review from nnixaa February 18, 2019 13:57
@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #1247 into master will increase coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
+ Coverage    79.3%   79.47%   +0.16%     
==========================================
  Files         232      232              
  Lines        7017     7019       +2     
  Branches      586      587       +1     
==========================================
+ Hits         5565     5578      +13     
+ Misses       1289     1272      -17     
- Partials      163      169       +6
Impacted Files Coverage Δ
...heme/components/datepicker/datepicker.directive.ts 70.49% <100%> (+8.82%) ⬆️
...heme/components/datepicker/datepicker.component.ts 81.54% <0%> (+0.59%) ⬆️

nnixaa
nnixaa previously approved these changes Feb 18, 2019
@nnixaa
Copy link
Collaborator

nnixaa commented Feb 20, 2019

@Tibing can we add a simple test?

@nnixaa nnixaa merged commit 799b8b8 into master Feb 21, 2019
@nnixaa nnixaa deleted the fix/datepicker-reactive-validation branch February 21, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nb-datepicker reactive form validation issue
3 participants