Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(smoke): include packages-smoke update into release #1258

Merged
merged 13 commits into from
Mar 14, 2019
Merged

feat(smoke): include packages-smoke update into release #1258

merged 13 commits into from
Mar 14, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Feb 22, 2019 •
edited
Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Also add all Nebular packages as dependencies in package.json. This way all Nebular dependencies will be installed.
Closes #1130.

@yggg yggg requested a review from Tibing February 22, 2019 07:42
@yggg yggg mentioned this pull request Feb 22, 2019
Closed
1 task
@yggg yggg changed the title refactor(smoke): remove nebular packages from dependencies feat(smoke): add all nebular packages in package.json Mar 12, 2019
@yggg yggg requested review from nnixaa and removed request for Tibing March 12, 2019 12:08
nnixaa
nnixaa previously approved these changes Mar 12, 2019
View reviewed changes
@yggg yggg changed the title feat(smoke): add all nebular packages in package.json feat(smoke): update packages-smoke dependencies during release Mar 12, 2019
@yggg yggg changed the title feat(smoke): update packages-smoke dependencies during release feat(smoke): include packages-smoke update into release Mar 12, 2019
@yggg yggg requested a review from nnixaa March 12, 2019 14:23
@yggg yggg merged commit 8db4b29 into akveo:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnixaa nnixaa nnixaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing @nebular/date-fns and @nebular/moment dependencies on packages-smoke repo
2 participants
@yggg @nnixaa