Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): prevent change detection of destroyed option #1329

Merged
merged 7 commits into from
Mar 29, 2019
Merged

fix(select): prevent change detection of destroyed option #1329

merged 7 commits into from
Mar 29, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Mar 28, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1210.

As turned out this issue related to reactive forms (angular/angular#27803).
writeValue called even if ng-select bound to [formControl] directive already destroyed.

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #1329 into master will increase coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
+ Coverage   80.65%   80.68%   +0.03%     
==========================================
  Files         232      232              
  Lines        7036     7032       -4     
  Branches      593      593              
==========================================
- Hits         5675     5674       -1     
+ Misses       1187     1184       -3     
  Partials      174      174
Impacted Files Coverage Δ
...mework/theme/components/select/select.component.ts 89.72% <83.33%> (+0.95%) ⬆️
...mework/theme/components/select/option.component.ts 94.59% <83.33%> (+2.28%) ⬆️

@Tibing Tibing merged commit 9e2245f into akveo:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants