Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(card): Eva style #1346

Merged
merged 20 commits into from
Apr 8, 2019
Merged

feat(card): Eva style #1346

merged 20 commits into from
Apr 8, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 3, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGES:

Following properties were renamed:
card-font-size -> card-text-font-size
card-font-weight -> card-text-font-weight
card-line-height -> card-text-line-height
card-bg -> card-background-color
card-border-type -> card-border-style
card-separator -> card-divider-color
card-header-fg -> card-header-text-color
card-header-primary-bg -> card-header-primary-background-color
card-header-info-bg -> card-header-info-background-color
card-header-success-bg -> card-header-success-background-color
card-header-warning-bg -> card-header-warning-background-color
card-header-danger-bg -> card-header-danger-background-color
card-header-disabled-bg -> card-header-disabled-background-color
card-margin -> card-margin-bottom
card-height-xxsmall -> card-height-tiny
card-height-small -> card-height-small
card-height-medium -> card-height-medium
card-height-large -> card-height-large
card-height-xlarge -> card-height-giant

Following properties were removed:
card-fg
card-fg-text
card-fg-heading
card-header-fg-heading
card-header-active-bg
card-header-active-fg
card-header-border-width
card-header-border-type
card-header-border-color
card-height-xsmall
card-height-xxlarge

All NbCardComponent static fields were removed. Removed fields:
SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE, STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER, ACCENT_PRIMARY, ACCENT_INFO, ACCENT_SUCCESS, ACCENT_WARNING, ACCENT_DANGER.
Use NbComponentStatus, NbComponentSize instead.

'disabled' status replaced with disabled input. 'active' status removed.
Card size class renamed from 'card-[size-name]' to 'size-[size-name]'.
Card status classes were renamed from '[status-name]-card' to
'status-[status-name]'.

NbCardComponent 'xsmall' and 'xxlarge' getters along with 'size-xsmall'
and 'size-xxlarge' removed.

NbCardComponent 'xxsmall', 'small', 'medium', 'large', 'xlarge' getters
renamed to 'tiny', 'small', 'medium', 'large', 'giant' accordingly.

yggg added 15 commits April 3, 2019 10:44
BREAKING CHANGES:

Following properties were renamed:
card-font-size -> card-text-font-size
card-font-weight -> card-text-font-weight
card-line-height -> card-text-line-height
card-bg -> card-background-color
card-border-type -> card-border-style
card-separator -> card-divider-color
card-header-fg -> card-header-text-color
card-header-primary-bg -> card-header-primary-background-color
card-header-info-bg -> card-header-info-background-color
card-header-success-bg -> card-header-success-background-color
card-header-warning-bg -> card-header-warning-background-color
card-header-danger-bg -> card-header-danger-background-color
card-header-disabled-bg -> card-header-disabled-background-color

Following properties were removed:
card-fg
card-fg-text
card-fg-heading
card-header-fg-heading
card-header-active-bg
card-header-active-fg
card-header-border-width
card-header-border-type
card-header-border-color
BREAKING CHANGES:
Following static class properties were replaced with NbCardSize,
NbCardStatus, NbCardAccent enums:
SIZE_XXSMALL
SIZE_XSMALL
SIZE_SMALL
SIZE_MEDIUM
SIZE_LARGE
SIZE_XLARGE
SIZE_XXLARGE
STATUS_PRIMARY
STATUS_INFO
STATUS_SUCCESS
STATUS_WARNING
STATUS_DANGER
ACCENT_PRIMARY
ACCENT_INFO
ACCENT_SUCCESS
ACCENT_WARNING
ACCENT_DANGER

'disabled' status replaced with disabled input. 'active' status removed.
Card size class renamed from card-[size-name] to size-[size-name].
Card status classes were renamed from '[status-name]-card' to
'status-[status-name]'.
BREAKING CHANGES:
'card-margin' renamed to 'card-margin-bottom'.
BREAKING CHANGE:

Following card theme properties were renamed:
card-height-xxsmall -> card-height-tiny
card-height-small -> card-height-small
card-height-medium -> card-height-medium
card-height-large -> card-height-large
card-height-xlarge -> card-height-giant

'card-height-xsmall', 'card-height-xxlarge' theme properties removed.

NbCardComponent 'xsmall' and 'xxlarge' getters along with 'size-xsmall'
and 'size-xxlarge' removed.

NbCardComponent 'xxsmall', 'small', 'medium', 'large', 'xlarge' getters
renamed to 'tiny', 'small', 'medium', 'large', 'giant' accordingly.
@yggg yggg requested a review from nnixaa April 3, 2019 08:16
nnixaa
nnixaa previously approved these changes Apr 4, 2019
Copy link
Collaborator

@nnixaa nnixaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OGON' 🔥

@nnixaa
Copy link
Collaborator

nnixaa commented Apr 5, 2019

image
Something went wrong with the example

@nnixaa
Copy link
Collaborator

nnixaa commented Apr 5, 2019

UPDATE:
it's fine, just styles interferance across separate examples (which we won't see in the docs).

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #1346 into next will decrease coverage by 0.07%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             next    #1346      +/-   ##
==========================================
- Coverage   81.96%   81.89%   -0.08%     
==========================================
  Files         237      237              
  Lines        7279     7256      -23     
  Branches      627      628       +1     
==========================================
- Hits         5966     5942      -24     
- Misses       1125     1126       +1     
  Partials      188      188
Impacted Files Coverage Δ
...e/components/card/flip-card/flip-card.component.ts 85.71% <ø> (ø) ⬆️
.../framework/theme/components/card/card.component.ts 92.98% <88.88%> (-3.27%) ⬇️

1 similar comment
@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #1346 into next will decrease coverage by 0.07%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             next    #1346      +/-   ##
==========================================
- Coverage   81.96%   81.89%   -0.08%     
==========================================
  Files         237      237              
  Lines        7279     7256      -23     
  Branches      627      628       +1     
==========================================
- Hits         5966     5942      -24     
- Misses       1125     1126       +1     
  Partials      188      188
Impacted Files Coverage Δ
...e/components/card/flip-card/flip-card.component.ts 85.71% <ø> (ø) ⬆️
.../framework/theme/components/card/card.component.ts 92.98% <88.88%> (-3.27%) ⬇️

@yggg yggg merged commit ec03c8c into akveo:next Apr 8, 2019
yggg added a commit that referenced this pull request Apr 17, 2019
BREAKING CHANGE:

Following properties were renamed:
card-font-size -> card-text-font-size
card-font-weight -> card-text-font-weight
card-line-height -> card-text-line-height
card-bg -> card-background-color
card-border-type -> card-border-style
card-separator -> card-divider-color
card-header-fg -> card-header-text-color
card-header-primary-bg -> card-header-primary-background-color
card-header-info-bg -> card-header-info-background-color
card-header-success-bg -> card-header-success-background-color
card-header-warning-bg -> card-header-warning-background-color
card-header-danger-bg -> card-header-danger-background-color
card-header-disabled-bg -> card-header-disabled-background-color
card-margin -> card-margin-bottom
card-height-xxsmall -> card-height-tiny
card-height-small -> card-height-small
card-height-medium -> card-height-medium
card-height-large -> card-height-large
card-height-xlarge -> card-height-giant

Following properties were removed:
card-fg
card-fg-text
card-fg-heading
card-header-fg-heading
card-header-active-bg
card-header-active-fg
card-header-border-width
card-header-border-type
card-header-border-color
card-height-xsmall
card-height-xxlarge

All NbCardComponent static fields were removed. Removed fields:
SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE, STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER, ACCENT_PRIMARY, ACCENT_INFO, ACCENT_SUCCESS, ACCENT_WARNING, ACCENT_DANGER.
Use NbComponentStatus, NbComponentSize instead.

'disabled' status replaced with disabled input. 'active' status removed.
Card size class renamed from 'card-[size-name]' to 'size-[size-name]'.
Card status classes were renamed from '[status-name]-card' to
'status-[status-name]'.

NbCardComponent 'xsmall' and 'xxlarge' getters along with 'size-xsmall'
and 'size-xxlarge' removed.

NbCardComponent 'xxsmall', 'small', 'medium', 'large', 'xlarge' getters
renamed to 'tiny', 'small', 'medium', 'large', 'giant' accordingly.
yggg added a commit that referenced this pull request May 27, 2019
BREAKING CHANGE:

Following properties were renamed:
card-font-size -> card-text-font-size
card-font-weight -> card-text-font-weight
card-line-height -> card-text-line-height
card-bg -> card-background-color
card-border-type -> card-border-style
card-separator -> card-divider-color
card-header-fg -> card-header-text-color
card-header-primary-bg -> card-header-primary-background-color
card-header-info-bg -> card-header-info-background-color
card-header-success-bg -> card-header-success-background-color
card-header-warning-bg -> card-header-warning-background-color
card-header-danger-bg -> card-header-danger-background-color
card-header-disabled-bg -> card-header-disabled-background-color
card-margin -> card-margin-bottom
card-height-xxsmall -> card-height-tiny
card-height-small -> card-height-small
card-height-medium -> card-height-medium
card-height-large -> card-height-large
card-height-xlarge -> card-height-giant

Following properties were removed:
card-fg
card-fg-text
card-fg-heading
card-header-fg-heading
card-header-active-bg
card-header-active-fg
card-header-border-width
card-header-border-type
card-header-border-color
card-height-xsmall
card-height-xxlarge

All NbCardComponent static fields were removed. Removed fields:
SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE, STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER, ACCENT_PRIMARY, ACCENT_INFO, ACCENT_SUCCESS, ACCENT_WARNING, ACCENT_DANGER.
Use NbComponentStatus, NbComponentSize instead.

'disabled' status replaced with disabled input. 'active' status removed.
Card size class renamed from 'card-[size-name]' to 'size-[size-name]'.
Card status classes were renamed from '[status-name]-card' to
'status-[status-name]'.

NbCardComponent 'xsmall' and 'xxlarge' getters along with 'size-xsmall'
and 'size-xxlarge' removed.

NbCardComponent 'xxsmall', 'small', 'medium', 'large', 'xlarge' getters
renamed to 'tiny', 'small', 'medium', 'large', 'giant' accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants