-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(card): Eva style #1346
feat(card): Eva style #1346
Conversation
BREAKING CHANGES: Following properties were renamed: card-font-size -> card-text-font-size card-font-weight -> card-text-font-weight card-line-height -> card-text-line-height card-bg -> card-background-color card-border-type -> card-border-style card-separator -> card-divider-color card-header-fg -> card-header-text-color card-header-primary-bg -> card-header-primary-background-color card-header-info-bg -> card-header-info-background-color card-header-success-bg -> card-header-success-background-color card-header-warning-bg -> card-header-warning-background-color card-header-danger-bg -> card-header-danger-background-color card-header-disabled-bg -> card-header-disabled-background-color Following properties were removed: card-fg card-fg-text card-fg-heading card-header-fg-heading card-header-active-bg card-header-active-fg card-header-border-width card-header-border-type card-header-border-color
BREAKING CHANGES: Following static class properties were replaced with NbCardSize, NbCardStatus, NbCardAccent enums: SIZE_XXSMALL SIZE_XSMALL SIZE_SMALL SIZE_MEDIUM SIZE_LARGE SIZE_XLARGE SIZE_XXLARGE STATUS_PRIMARY STATUS_INFO STATUS_SUCCESS STATUS_WARNING STATUS_DANGER ACCENT_PRIMARY ACCENT_INFO ACCENT_SUCCESS ACCENT_WARNING ACCENT_DANGER 'disabled' status replaced with disabled input. 'active' status removed. Card size class renamed from card-[size-name] to size-[size-name]. Card status classes were renamed from '[status-name]-card' to 'status-[status-name]'.
BREAKING CHANGES: 'card-margin' renamed to 'card-margin-bottom'.
BREAKING CHANGE: Following card theme properties were renamed: card-height-xxsmall -> card-height-tiny card-height-small -> card-height-small card-height-medium -> card-height-medium card-height-large -> card-height-large card-height-xlarge -> card-height-giant 'card-height-xsmall', 'card-height-xxlarge' theme properties removed. NbCardComponent 'xsmall' and 'xxlarge' getters along with 'size-xsmall' and 'size-xxlarge' removed. NbCardComponent 'xxsmall', 'small', 'medium', 'large', 'xlarge' getters renamed to 'tiny', 'small', 'medium', 'large', 'giant' accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OGON' 🔥
UPDATE: |
Codecov Report
@@ Coverage Diff @@
## next #1346 +/- ##
==========================================
- Coverage 81.96% 81.89% -0.08%
==========================================
Files 237 237
Lines 7279 7256 -23
Branches 627 628 +1
==========================================
- Hits 5966 5942 -24
- Misses 1125 1126 +1
Partials 188 188
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## next #1346 +/- ##
==========================================
- Coverage 81.96% 81.89% -0.08%
==========================================
Files 237 237
Lines 7279 7256 -23
Branches 627 628 +1
==========================================
- Hits 5966 5942 -24
- Misses 1125 1126 +1
Partials 188 188
|
BREAKING CHANGE: Following properties were renamed: card-font-size -> card-text-font-size card-font-weight -> card-text-font-weight card-line-height -> card-text-line-height card-bg -> card-background-color card-border-type -> card-border-style card-separator -> card-divider-color card-header-fg -> card-header-text-color card-header-primary-bg -> card-header-primary-background-color card-header-info-bg -> card-header-info-background-color card-header-success-bg -> card-header-success-background-color card-header-warning-bg -> card-header-warning-background-color card-header-danger-bg -> card-header-danger-background-color card-header-disabled-bg -> card-header-disabled-background-color card-margin -> card-margin-bottom card-height-xxsmall -> card-height-tiny card-height-small -> card-height-small card-height-medium -> card-height-medium card-height-large -> card-height-large card-height-xlarge -> card-height-giant Following properties were removed: card-fg card-fg-text card-fg-heading card-header-fg-heading card-header-active-bg card-header-active-fg card-header-border-width card-header-border-type card-header-border-color card-height-xsmall card-height-xxlarge All NbCardComponent static fields were removed. Removed fields: SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE, STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER, ACCENT_PRIMARY, ACCENT_INFO, ACCENT_SUCCESS, ACCENT_WARNING, ACCENT_DANGER. Use NbComponentStatus, NbComponentSize instead. 'disabled' status replaced with disabled input. 'active' status removed. Card size class renamed from 'card-[size-name]' to 'size-[size-name]'. Card status classes were renamed from '[status-name]-card' to 'status-[status-name]'. NbCardComponent 'xsmall' and 'xxlarge' getters along with 'size-xsmall' and 'size-xxlarge' removed. NbCardComponent 'xxsmall', 'small', 'medium', 'large', 'xlarge' getters renamed to 'tiny', 'small', 'medium', 'large', 'giant' accordingly.
BREAKING CHANGE: Following properties were renamed: card-font-size -> card-text-font-size card-font-weight -> card-text-font-weight card-line-height -> card-text-line-height card-bg -> card-background-color card-border-type -> card-border-style card-separator -> card-divider-color card-header-fg -> card-header-text-color card-header-primary-bg -> card-header-primary-background-color card-header-info-bg -> card-header-info-background-color card-header-success-bg -> card-header-success-background-color card-header-warning-bg -> card-header-warning-background-color card-header-danger-bg -> card-header-danger-background-color card-header-disabled-bg -> card-header-disabled-background-color card-margin -> card-margin-bottom card-height-xxsmall -> card-height-tiny card-height-small -> card-height-small card-height-medium -> card-height-medium card-height-large -> card-height-large card-height-xlarge -> card-height-giant Following properties were removed: card-fg card-fg-text card-fg-heading card-header-fg-heading card-header-active-bg card-header-active-fg card-header-border-width card-header-border-type card-header-border-color card-height-xsmall card-height-xxlarge All NbCardComponent static fields were removed. Removed fields: SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE, STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER, ACCENT_PRIMARY, ACCENT_INFO, ACCENT_SUCCESS, ACCENT_WARNING, ACCENT_DANGER. Use NbComponentStatus, NbComponentSize instead. 'disabled' status replaced with disabled input. 'active' status removed. Card size class renamed from 'card-[size-name]' to 'size-[size-name]'. Card status classes were renamed from '[status-name]-card' to 'status-[status-name]'. NbCardComponent 'xsmall' and 'xxlarge' getters along with 'size-xsmall' and 'size-xxlarge' removed. NbCardComponent 'xxsmall', 'small', 'medium', 'large', 'xlarge' getters renamed to 'tiny', 'small', 'medium', 'large', 'giant' accordingly.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
BREAKING CHANGES:
Following properties were renamed:
card-font-size -> card-text-font-size
card-font-weight -> card-text-font-weight
card-line-height -> card-text-line-height
card-bg -> card-background-color
card-border-type -> card-border-style
card-separator -> card-divider-color
card-header-fg -> card-header-text-color
card-header-primary-bg -> card-header-primary-background-color
card-header-info-bg -> card-header-info-background-color
card-header-success-bg -> card-header-success-background-color
card-header-warning-bg -> card-header-warning-background-color
card-header-danger-bg -> card-header-danger-background-color
card-header-disabled-bg -> card-header-disabled-background-color
card-margin -> card-margin-bottom
card-height-xxsmall -> card-height-tiny
card-height-small -> card-height-small
card-height-medium -> card-height-medium
card-height-large -> card-height-large
card-height-xlarge -> card-height-giant
Following properties were removed:
card-fg
card-fg-text
card-fg-heading
card-header-fg-heading
card-header-active-bg
card-header-active-fg
card-header-border-width
card-header-border-type
card-header-border-color
card-height-xsmall
card-height-xxlarge
All NbCardComponent static fields were removed. Removed fields:
SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE, STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER, ACCENT_PRIMARY, ACCENT_INFO, ACCENT_SUCCESS, ACCENT_WARNING, ACCENT_DANGER.
Use NbComponentStatus, NbComponentSize instead.
'disabled' status replaced with disabled input. 'active' status removed.
Card size class renamed from 'card-[size-name]' to 'size-[size-name]'.
Card status classes were renamed from '[status-name]-card' to
'status-[status-name]'.
NbCardComponent 'xsmall' and 'xxlarge' getters along with 'size-xsmall'
and 'size-xxlarge' removed.
NbCardComponent 'xxsmall', 'small', 'medium', 'large', 'xlarge' getters
renamed to 'tiny', 'small', 'medium', 'large', 'giant' accordingly.