Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): native date service addMonth date overflow #1347

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Apr 3, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1332

Resolves the issue with date overflow while adding a month in native date service.

@Tibing Tibing requested review from nnixaa and yggg April 3, 2019 10:16
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #1347 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
+ Coverage   81.13%   81.13%   +<.01%     
==========================================
  Files         232      232              
  Lines        7044     7046       +2     
  Branches      596      596              
==========================================
+ Hits         5715     5717       +2     
  Misses       1152     1152              
  Partials      177      177
Impacted Files Coverage Δ
...nents/calendar-kit/services/native-date.service.ts 98.57% <100%> (+0.04%) ⬆️

@nnixaa nnixaa merged commit ffd386c into master Apr 8, 2019
@nnixaa nnixaa deleted the fix/calendar branch April 8, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar on March shows Februari ending on the 31st
3 participants