Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spinner): Eva style #1351

Merged
merged 19 commits into from
Apr 8, 2019
Merged

feat(spinner): Eva style #1351

merged 19 commits into from
Apr 8, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 4, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGES:

Following spinner theme properties were renamed:
spinner-bg -> spinner-background-color
spinner-circle-bg -> spinner-circle-filled-color
spinner-fg -> spinner-text-color
spinner-primary-bg -> spinner-primary-circle-filled-color
spinner-info-bg -> spinner-info-circle-filled-color
spinner-success-bg -> spinner-success-circle-filled-color
spinner-warning-bg -> spinner-warning-circle-filled-color
spinner-danger-bg -> spinner-danger-circle-filled-color
spinner-xsmall -> spinner-height-tiny
spinner-small -> spinner-height-small
spinner-medium -> spinner-height-medium
spinner-large -> spinner-height-large
spinner-xlarge -> spinner-height-giant

Following properties were removed:
spinner-xxsmall
spinner-xxlarge
spinner-disabled-bg
spinner-disabled-fg
spinner-active-bg

'active' and 'disabled' along with NbSpinnerComponent STATUS_ACTIVE, STATUS_DISABLED static properties statuses were removed.

Following NbSpinnerComponent static properties were removed:
SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE, STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER.

Classes '[size-name]-spinner' changed to 'size-[size-name]'.
Classes '[status-name]-spinner' changed to 'status-[status-name]'.

NbSpinnerComponent 'xxsmall' and 'xxlarge' getters removed.

yggg added 12 commits April 4, 2019 10:26
BREAKING CHANGES:

Following spinner theme properties were renamed:
spinner-bg -> spinner-background-color
spinner-circle-bg -> spinner-circle-filled-color
spinner-fg -> spinner-text-color
spinner-primary-bg -> spinner-primary-circle-filled-color
spinner-info-bg -> spinner-info-circle-filled-color
spinner-success-bg -> spinner-success-circle-filled-color
spinner-warning-bg -> spinner-warning-circle-filled-color
spinner-danger-bg -> spinner-danger-circle-filled-color
spinner-xxsmall -> spinner-height-xxsmall
spinner-xsmall -> spinner-height-xsmall
spinner-small -> spinner-height-small
spinner-medium -> spinner-height-medium
spinner-large -> spinner-height-large
spinner-xlarge -> spinner-height-xlarge
spinner-xxlarge -> spinner-height-xxlarge

Following properties were removed:
spinner-disabled-bg
spinner-disabled-fg
spinner-active-bg
BREAKING CHANGES:
'active' and 'disabled' along with STATUS_ACTIVE, STATUS_DISABLED static
properties statuses were removed.
BREAKING CHANGES:
Following NbSpinnerComponent static properties were replaced by enums:
SIZE_XXSMALL
SIZE_XSMALL
SIZE_SMALL
SIZE_MEDIUM
SIZE_LARGE
SIZE_XLARGE
SIZE_XXLARGE
STATUS_PRIMARY
STATUS_INFO
STATUS_SUCCESS
STATUS_WARNING
STATUS_DANGER
BREAKING CHANGES:
Classes '[size-name]-spinner' changed to 'size-[size-name]'.
Classes '[status-name]-spinner' changed to 'status-[status-name]'.
BREAKING CHANGE:

'xxsmall' and 'xxlarge' spinned sizes removed.
'spinner-height-xxsmall' and 'spinner-height-xxlarge' theme variables
removed along with 'xxsmall' and 'xxlarge' getters and corresponding
classes.
@yggg yggg requested a review from nnixaa April 4, 2019 08:54
Copy link
Collaborator

@nnixaa nnixaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
For sizes example let's put colored spinner, as otherwise you can barely see it

@yggg
Copy link
Contributor Author

yggg commented Apr 5, 2019

@nnixaa Maybe it's better to change default circle color or spinner background?
Done in 092f827.

@yggg yggg requested a review from nnixaa April 5, 2019 11:59
@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #1351 into next will decrease coverage by 0.03%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             next    #1351      +/-   ##
==========================================
- Coverage   81.89%   81.85%   -0.04%     
==========================================
  Files         237      237              
  Lines        7256     7230      -26     
  Branches      628      628              
==========================================
- Hits         5942     5918      -24     
+ Misses       1126     1124       -2     
  Partials      188      188
Impacted Files Coverage Δ
...work/theme/components/spinner/spinner.component.ts 100% <100%> (+3.84%) ⬆️
...work/theme/components/spinner/spinner.directive.ts 34.21% <75%> (ø) ⬆️

@yggg yggg merged commit 02d2141 into akveo:next Apr 8, 2019
yggg added a commit that referenced this pull request Apr 17, 2019
BREAKING CHANGE:

Following spinner theme properties were renamed:
spinner-bg -> spinner-background-color
spinner-circle-bg -> spinner-circle-filled-color
spinner-fg -> spinner-text-color
spinner-primary-bg -> spinner-primary-circle-filled-color
spinner-info-bg -> spinner-info-circle-filled-color
spinner-success-bg -> spinner-success-circle-filled-color
spinner-warning-bg -> spinner-warning-circle-filled-color
spinner-danger-bg -> spinner-danger-circle-filled-color
spinner-xsmall -> spinner-height-tiny
spinner-small -> spinner-height-small
spinner-medium -> spinner-height-medium
spinner-large -> spinner-height-large
spinner-xlarge -> spinner-height-giant

Following properties were removed:
spinner-xxsmall
spinner-xxlarge
spinner-disabled-bg
spinner-disabled-fg
spinner-active-bg

'active' and 'disabled' along with NbSpinnerComponent STATUS_ACTIVE, STATUS_DISABLED static properties statuses were removed.

Following NbSpinnerComponent static properties were removed:
SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE, STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER.

Classes '[size-name]-spinner' changed to 'size-[size-name]'.
Classes '[status-name]-spinner' changed to 'status-[status-name]'.

NbSpinnerComponent 'xxsmall' and 'xxlarge' getters removed.
yggg added a commit that referenced this pull request May 27, 2019
BREAKING CHANGE:

Following spinner theme properties were renamed:
spinner-bg -> spinner-background-color
spinner-circle-bg -> spinner-circle-filled-color
spinner-fg -> spinner-text-color
spinner-primary-bg -> spinner-primary-circle-filled-color
spinner-info-bg -> spinner-info-circle-filled-color
spinner-success-bg -> spinner-success-circle-filled-color
spinner-warning-bg -> spinner-warning-circle-filled-color
spinner-danger-bg -> spinner-danger-circle-filled-color
spinner-xsmall -> spinner-height-tiny
spinner-small -> spinner-height-small
spinner-medium -> spinner-height-medium
spinner-large -> spinner-height-large
spinner-xlarge -> spinner-height-giant

Following properties were removed:
spinner-xxsmall
spinner-xxlarge
spinner-disabled-bg
spinner-disabled-fg
spinner-active-bg

'active' and 'disabled' along with NbSpinnerComponent STATUS_ACTIVE, STATUS_DISABLED static properties statuses were removed.

Following NbSpinnerComponent static properties were removed:
SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE, STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER.

Classes '[size-name]-spinner' changed to 'size-[size-name]'.
Classes '[status-name]-spinner' changed to 'status-[status-name]'.

NbSpinnerComponent 'xxsmall' and 'xxlarge' getters removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants