-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spinner): Eva style #1351
Merged
Merged
feat(spinner): Eva style #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: Following spinner theme properties were renamed: spinner-bg -> spinner-background-color spinner-circle-bg -> spinner-circle-filled-color spinner-fg -> spinner-text-color spinner-primary-bg -> spinner-primary-circle-filled-color spinner-info-bg -> spinner-info-circle-filled-color spinner-success-bg -> spinner-success-circle-filled-color spinner-warning-bg -> spinner-warning-circle-filled-color spinner-danger-bg -> spinner-danger-circle-filled-color spinner-xxsmall -> spinner-height-xxsmall spinner-xsmall -> spinner-height-xsmall spinner-small -> spinner-height-small spinner-medium -> spinner-height-medium spinner-large -> spinner-height-large spinner-xlarge -> spinner-height-xlarge spinner-xxlarge -> spinner-height-xxlarge Following properties were removed: spinner-disabled-bg spinner-disabled-fg spinner-active-bg
BREAKING CHANGES: 'active' and 'disabled' along with STATUS_ACTIVE, STATUS_DISABLED static properties statuses were removed.
BREAKING CHANGES: Following NbSpinnerComponent static properties were replaced by enums: SIZE_XXSMALL SIZE_XSMALL SIZE_SMALL SIZE_MEDIUM SIZE_LARGE SIZE_XLARGE SIZE_XXLARGE STATUS_PRIMARY STATUS_INFO STATUS_SUCCESS STATUS_WARNING STATUS_DANGER
BREAKING CHANGES: Classes '[size-name]-spinner' changed to 'size-[size-name]'. Classes '[status-name]-spinner' changed to 'status-[status-name]'.
BREAKING CHANGE: 'xxsmall' and 'xxlarge' spinned sizes removed. 'spinner-height-xxsmall' and 'spinner-height-xxlarge' theme variables removed along with 'xxsmall' and 'xxlarge' getters and corresponding classes.
nnixaa
requested changes
Apr 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nnixaa
approved these changes
Apr 5, 2019
Codecov Report
@@ Coverage Diff @@
## next #1351 +/- ##
==========================================
- Coverage 81.89% 81.85% -0.04%
==========================================
Files 237 237
Lines 7256 7230 -26
Branches 628 628
==========================================
- Hits 5942 5918 -24
+ Misses 1126 1124 -2
Partials 188 188
|
yggg
added a commit
that referenced
this pull request
Apr 17, 2019
BREAKING CHANGE: Following spinner theme properties were renamed: spinner-bg -> spinner-background-color spinner-circle-bg -> spinner-circle-filled-color spinner-fg -> spinner-text-color spinner-primary-bg -> spinner-primary-circle-filled-color spinner-info-bg -> spinner-info-circle-filled-color spinner-success-bg -> spinner-success-circle-filled-color spinner-warning-bg -> spinner-warning-circle-filled-color spinner-danger-bg -> spinner-danger-circle-filled-color spinner-xsmall -> spinner-height-tiny spinner-small -> spinner-height-small spinner-medium -> spinner-height-medium spinner-large -> spinner-height-large spinner-xlarge -> spinner-height-giant Following properties were removed: spinner-xxsmall spinner-xxlarge spinner-disabled-bg spinner-disabled-fg spinner-active-bg 'active' and 'disabled' along with NbSpinnerComponent STATUS_ACTIVE, STATUS_DISABLED static properties statuses were removed. Following NbSpinnerComponent static properties were removed: SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE, STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER. Classes '[size-name]-spinner' changed to 'size-[size-name]'. Classes '[status-name]-spinner' changed to 'status-[status-name]'. NbSpinnerComponent 'xxsmall' and 'xxlarge' getters removed.
yggg
added a commit
that referenced
this pull request
May 27, 2019
BREAKING CHANGE: Following spinner theme properties were renamed: spinner-bg -> spinner-background-color spinner-circle-bg -> spinner-circle-filled-color spinner-fg -> spinner-text-color spinner-primary-bg -> spinner-primary-circle-filled-color spinner-info-bg -> spinner-info-circle-filled-color spinner-success-bg -> spinner-success-circle-filled-color spinner-warning-bg -> spinner-warning-circle-filled-color spinner-danger-bg -> spinner-danger-circle-filled-color spinner-xsmall -> spinner-height-tiny spinner-small -> spinner-height-small spinner-medium -> spinner-height-medium spinner-large -> spinner-height-large spinner-xlarge -> spinner-height-giant Following properties were removed: spinner-xxsmall spinner-xxlarge spinner-disabled-bg spinner-disabled-fg spinner-active-bg 'active' and 'disabled' along with NbSpinnerComponent STATUS_ACTIVE, STATUS_DISABLED static properties statuses were removed. Following NbSpinnerComponent static properties were removed: SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE, STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER. Classes '[size-name]-spinner' changed to 'size-[size-name]'. Classes '[status-name]-spinner' changed to 'status-[status-name]'. NbSpinnerComponent 'xxsmall' and 'xxlarge' getters removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
BREAKING CHANGES:
Following spinner theme properties were renamed:
spinner-bg -> spinner-background-color
spinner-circle-bg -> spinner-circle-filled-color
spinner-fg -> spinner-text-color
spinner-primary-bg -> spinner-primary-circle-filled-color
spinner-info-bg -> spinner-info-circle-filled-color
spinner-success-bg -> spinner-success-circle-filled-color
spinner-warning-bg -> spinner-warning-circle-filled-color
spinner-danger-bg -> spinner-danger-circle-filled-color
spinner-xsmall -> spinner-height-tiny
spinner-small -> spinner-height-small
spinner-medium -> spinner-height-medium
spinner-large -> spinner-height-large
spinner-xlarge -> spinner-height-giant
Following properties were removed:
spinner-xxsmall
spinner-xxlarge
spinner-disabled-bg
spinner-disabled-fg
spinner-active-bg
'active' and 'disabled' along with NbSpinnerComponent STATUS_ACTIVE, STATUS_DISABLED static properties statuses were removed.
Following NbSpinnerComponent static properties were removed:
SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE, STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER.
Classes '[size-name]-spinner' changed to 'size-[size-name]'.
Classes '[status-name]-spinner' changed to 'status-[status-name]'.
NbSpinnerComponent 'xxsmall' and 'xxlarge' getters removed.