feat(icon): Eva theme #1404
Merged
feat(icon): Eva theme #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: NbIconComponent status static fields removed. STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER. 'status' field now uses common NbComponentStatus type. NbIconComponent statuc class names renamed to 'status-[status-name]'.
BREAKING CHANGES: Following theme properties were renamed: icon-primary-fg -> icon-primary-color icon-info-fg -> icon-info-color icon-success-fg -> icon-success-color icon-warning-fg -> icon-warning-color icon-danger-fg -> icon-danger-color
Codecov Report
@@ Coverage Diff @@
## next #1404 +/- ##
=========================================
- Coverage 82.61% 82.6% -0.02%
=========================================
Files 237 237
Lines 7282 7277 -5
Branches 637 637
=========================================
- Hits 6016 6011 -5
Misses 1079 1079
Partials 187 187
|
nnixaa
approved these changes
Apr 21, 2019
yggg
added a commit
that referenced
this pull request
May 27, 2019
BREAKING CHANGE: NbIconComponent status static fields removed. STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER. 'status' field now uses common NbComponentStatus type. NbIconComponent static class names renamed to 'status-[status-name]'. Following theme properties were renamed: icon-primary-fg -> icon-primary-color icon-info-fg -> icon-info-color icon-success-fg -> icon-success-color icon-warning-fg -> icon-warning-color icon-danger-fg -> icon-danger-color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
BREAKING CHANGE:
NbIconComponent status static fields removed.
STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER.
'status' field now uses common NbComponentStatus type.
NbIconComponent static class names renamed to 'status-[status-name]'.
Following theme properties were renamed:
icon-primary-fg -> icon-primary-color
icon-info-fg -> icon-info-color
icon-success-fg -> icon-success-color
icon-warning-fg -> icon-warning-color
icon-danger-fg -> icon-danger-color