-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(badge): Eva theme #1407
Merged
Merged
feat(badge): Eva theme #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: NbBadgeComponent status static fields removed. STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER.
BREAKING CHANGE: NbBadgeComponent position static fields replaced with NbBadgePosition type. Removed properties: TOP_LEFT, TOP_RIGHT, BOTTOM_LEFT, BOTTOM_RIGHT, TOP_START, TOP_END, BOTTOM_START, BOTTOM_END.
BREAKING CHANGE: Badge status class now set on host element
Logical badge position now calculated via css. BREAKING CHANGE: NbBadgeComponent 'positionClass' getter removed. Badge position class set on host element. Position class names prefixed with 'position-'.
BREAKING CHANGE: Following theme properties were renamed: badge-fg-text -> badge-[status]-text-color badge-primary-bg-color -> badge-primary-background-color badge-success-bg-color -> badge-success-background-color badge-info-bg-color -> badge-info-background-color badge-warning-bg-color -> badge-warning-background-color badge-danger-bg-color -> badge-danger-background-color
nnixaa
previously approved these changes
Apr 22, 2019
Codecov Report
@@ Coverage Diff @@
## next #1407 +/- ##
==========================================
+ Coverage 82.68% 82.71% +0.03%
==========================================
Files 238 238
Lines 7227 7228 +1
Branches 637 634 -3
==========================================
+ Hits 5976 5979 +3
Misses 1064 1064
+ Partials 187 185 -2
|
nnixaa
approved these changes
Apr 22, 2019
yggg
added a commit
that referenced
this pull request
May 27, 2019
BREAKING CHANGE: NbBadgeComponent status static fields removed. STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER. NbBadgeComponent position static fields replaced with NbBadgePosition type. Removed properties: TOP_LEFT, TOP_RIGHT, BOTTOM_LEFT, BOTTOM_RIGHT, TOP_START, TOP_END, BOTTOM_START, BOTTOM_END. Badge status class now set on host element NbBadgeComponent 'positionClass' getter removed. Badge position class set on host element. Position class names prefixed with 'position-'. Following theme properties were renamed: badge-fg-text -> badge-[status]-text-color badge-primary-bg-color -> badge-primary-background-color badge-success-bg-color -> badge-success-background-color badge-info-bg-color -> badge-info-background-color badge-warning-bg-color -> badge-warning-background-color badge-danger-bg-color -> badge-danger-background-color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
BREAKING CHANGE:
NbBadgeComponent status static fields removed.
STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING,
STATUS_DANGER.
NbBadgeComponent position static fields replaced with NbBadgePosition type.
Removed properties: TOP_LEFT, TOP_RIGHT, BOTTOM_LEFT, BOTTOM_RIGHT,
TOP_START, TOP_END, BOTTOM_START, BOTTOM_END.
Badge status class now set on host element
NbBadgeComponent 'positionClass' getter removed.
Badge position class set on host element.
Position class names prefixed with 'position-'.
Following theme properties were renamed:
badge-fg-text -> badge-[status]-text-color
badge-primary-bg-color -> badge-primary-background-color
badge-success-bg-color -> badge-success-background-color
badge-info-bg-color -> badge-info-background-color
badge-warning-bg-color -> badge-warning-background-color
badge-danger-bg-color -> badge-danger-background-color