Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toastr): Eva style #1411

Merged
merged 10 commits into from
Apr 24, 2019
Merged

feat(toastr): Eva style #1411

merged 10 commits into from
Apr 24, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 22, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGE:

NbToastStatus enum removed. Toastr now uses common NbComponentstatus type.

NbToastComponent status class names changed to 'status-[status-name]'.
'default' class removed.

Following theme properties were renamed:
toastr-bg -> toastr-background
toastr-fg -> toastr-text-color
toastr-border -> toastr-border-style, toastr-border-width

'toastr-icon-radius' removed.

yggg added 5 commits April 22, 2019 10:14
Not relevant anymore since toastr now uses nb-icon.
BREAKING CHANGE:

NbToastStatus enum removed. Toastr now uses common NbComponentstatus type.

NbToastComponent status class names changed to 'status-[status-name]'.
'default' class removed.
BREAKING CHANGE:

'toastr-icon-radius' removed.

Following theme properties were renamed:
toastr-bg -> toastr-background
toastr-fg -> toastr-text-color
toastr-border -> toastr-border-style, toastr-border-width
@yggg yggg requested a review from nnixaa April 22, 2019 11:18
@nnixaa
Copy link
Collaborator

nnixaa commented Apr 22, 2019

image

The font is wrong I suppose. Otherwise looks good.

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #1411 into next will decrease coverage by 0.01%.
The diff coverage is 62.5%.

@@            Coverage Diff            @@
##             next   #1411      +/-   ##
=========================================
- Coverage   82.51%   82.5%   -0.02%     
=========================================
  Files         238     238              
  Lines        7281    7270      -11     
  Branches      647     647              
=========================================
- Hits         6008    5998      -10     
+ Misses       1084    1083       -1     
  Partials      189     189
Impacted Files Coverage Δ
src/framework/theme/components/toastr/model.ts 100% <ø> (ø) ⬆️
...ramework/theme/components/toastr/toastr.service.ts 72.16% <100%> (-0.29%) ⬇️
...framework/theme/components/toastr/toastr-config.ts 94.73% <100%> (-0.27%) ⬇️
...amework/theme/components/toastr/toast.component.ts 60.71% <14.28%> (+0.71%) ⬆️

@yggg yggg merged commit ccdaf9b into akveo:next Apr 24, 2019
yggg added a commit that referenced this pull request May 27, 2019
BREAKING CHANGE:

NbToastStatus enum removed. Toastr now uses common NbComponentstatus type.

NbToastComponent status class names changed to 'status-[status-name]'.
'default' class removed.

Following theme properties were renamed:
toastr-bg -> toastr-background
toastr-fg -> toastr-text-color
toastr-border -> toastr-border-style, toastr-border-width

'toastr-icon-radius' removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants