-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toastr): Eva style #1411
Merged
Merged
feat(toastr): Eva style #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not relevant anymore since toastr now uses nb-icon.
BREAKING CHANGE: NbToastStatus enum removed. Toastr now uses common NbComponentstatus type. NbToastComponent status class names changed to 'status-[status-name]'. 'default' class removed.
BREAKING CHANGE: 'toastr-icon-radius' removed. Following theme properties were renamed: toastr-bg -> toastr-background toastr-fg -> toastr-text-color toastr-border -> toastr-border-style, toastr-border-width
nnixaa
approved these changes
Apr 24, 2019
Codecov Report
@@ Coverage Diff @@
## next #1411 +/- ##
=========================================
- Coverage 82.51% 82.5% -0.02%
=========================================
Files 238 238
Lines 7281 7270 -11
Branches 647 647
=========================================
- Hits 6008 5998 -10
+ Misses 1084 1083 -1
Partials 189 189
|
yggg
added a commit
that referenced
this pull request
May 27, 2019
BREAKING CHANGE: NbToastStatus enum removed. Toastr now uses common NbComponentstatus type. NbToastComponent status class names changed to 'status-[status-name]'. 'default' class removed. Following theme properties were renamed: toastr-bg -> toastr-background toastr-fg -> toastr-text-color toastr-border -> toastr-border-style, toastr-border-width 'toastr-icon-radius' removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
BREAKING CHANGE:
NbToastStatus enum removed. Toastr now uses common NbComponentstatus type.
NbToastComponent status class names changed to 'status-[status-name]'.
'default' class removed.
Following theme properties were renamed:
toastr-bg -> toastr-background
toastr-fg -> toastr-text-color
toastr-border -> toastr-border-style, toastr-border-width
'toastr-icon-radius' removed.