feat(select): keyboard support #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select could be opened with up and down arrows. Options became focusable. It's possible to select an option with enter and space keys.
This way option text is styled as option text not as input label.
…to feat/select-keyboard-support
Codecov Report
@@ Coverage Diff @@
## next #1417 +/- ##
==========================================
- Coverage 82.62% 82.57% -0.06%
==========================================
Files 238 240 +2
Lines 7293 7328 +35
Branches 651 654 +3
==========================================
+ Hits 6026 6051 +25
- Misses 1079 1088 +9
- Partials 188 189 +1
|
Tibing
requested changes
Apr 25, 2019
| @@ -672,7 +670,19 @@ export class NbSelectComponent<T> implements OnInit, AfterViewInit, AfterContent | |||
|
|
|||
| show() { | |||
| if (this.isHidden) { | |||
| if (!this.ref) { | |||
There was a problem hiding this comment.
Let's not put if in if. Please, move in the separate function.
| this.ref.attach(this.portal); | ||
| if (this.selectionModel.length) { |
There was a problem hiding this comment.
Let's not put if in if. Please, move in the separate function.
Tibing
approved these changes
Apr 25, 2019
yggg
added a commit
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves: