Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): Eva theme #1419

Merged
merged 4 commits into from
Apr 25, 2019
Merged

feat(search): Eva theme #1419

merged 4 commits into from
Apr 25, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 24, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGE:

Following theme properties renamed:
search-bg -> search-background-color
search-bg-secondary -> search-extra-background-color
search-text -> search-text-color
search-info -> search-info-text-color
search-dash -> search-divider-color
search-placeholder -> search-placeholder-text-color

Following theme properties removed:
search-btn-open-fg
search-btn-close-fg

yggg added 4 commits April 24, 2019 19:35
BREAKING CHANGE:

Following theme properties renamed:
search-bg -> search-background-color
search-bg-secondary -> search-extra-background-color
search-text -> search-text-color
search-info -> search-info-text-color
search-dash -> search-divider-color
search-placeholder -> search-placeholder-text-color

Following theme properties removed:
search-btn-open-fg
search-btn-close-fg
@yggg yggg requested a review from nnixaa April 24, 2019 18:51
@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #1419 into next will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next    #1419      +/-   ##
==========================================
+ Coverage   82.61%   82.61%   +<.01%     
==========================================
  Files         238      238              
  Lines        7294     7295       +1     
  Branches      651      651              
==========================================
+ Hits         6026     6027       +1     
  Misses       1080     1080              
  Partials      188      188
Impacted Files Coverage Δ
...framework/theme/components/search/search.module.ts 100% <100%> (ø) ⬆️
...mework/theme/components/search/search.component.ts 79.48% <100%> (ø) ⬆️

@yggg yggg merged commit 5d923a6 into akveo:next Apr 25, 2019
yggg added a commit that referenced this pull request May 27, 2019
BREAKING CHANGE:

Following theme properties renamed:
search-bg -> search-background-color
search-bg-secondary -> search-extra-background-color
search-text -> search-text-color
search-info -> search-info-text-color
search-dash -> search-divider-color
search-placeholder -> search-placeholder-text-color

Following theme properties removed:
search-btn-open-fg
search-btn-close-fg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants