-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(menu): Eva style #1421
Merged
Merged
feat(menu): Eva style #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Following theme variables were removed: menu-font-family -> menu-text-font-family menu-font-size -> menu-text-font-size menu-font-weight -> menu-text-font-weight menu-fg -> menu-text-color menu-bg -> menu-background-color menu-active-fg -> menu-item-active-text-color menu-active-bg -> menu-item-active-background-color menu-submenu-bg -> menu-submenu-background-color menu-submenu-fg -> menu-submenu-text-color menu-submenu-active-fg -> menu-submenu-item-active-text-color menu-submenu-active-bg -> menu-submenu-item-active-background-color menu-submenu-active-border-color -> menu-submenu-item-active-border-color menu-submenu-hover-fg -> menu-item-hover-text-color menu-submenu-hover-bg -> menu-item-hover-background-color menu-group-fg -> menu-group-text-color menu-item-separator -> menu-item-divider-color menu-icon-font-size -> menu-item-icon-width menu-icon-margin -> menu-item-icon-margin menu-icon-color -> menu-item-icon-color menu-icon-active-color -> menu-item-icon-active-color Following theme properties were removed: menu-submenu-active-shadow menu-active-font-weight menu-submenu-item-container-padding menu-group-font-weight menu-group-font-size menu-group-padding
nnixaa
approved these changes
Apr 25, 2019
Codecov Report
@@ Coverage Diff @@
## next #1421 +/- ##
==========================================
+ Coverage 82.61% 82.62% +<.01%
==========================================
Files 238 238
Lines 7295 7293 -2
Branches 651 651
==========================================
- Hits 6027 6026 -1
+ Misses 1080 1079 -1
Partials 188 188
|
yggg
added a commit
that referenced
this pull request
May 27, 2019
BREAKING CHANGE: Removed inverse mode. NbMenuComponent 'autoCollapseValue' property changed to 'autoCollapse'. Following theme variables were removed: menu-font-family -> menu-text-font-family menu-font-size -> menu-text-font-size menu-font-weight -> menu-text-font-weight menu-fg -> menu-text-color menu-bg -> menu-background-color menu-active-fg -> menu-item-active-text-color menu-active-bg -> menu-item-active-background-color menu-submenu-bg -> menu-submenu-background-color menu-submenu-fg -> menu-submenu-text-color menu-submenu-active-fg -> menu-submenu-item-active-text-color menu-submenu-active-bg -> menu-submenu-item-active-background-color menu-submenu-active-border-color -> menu-submenu-item-active-border-color menu-submenu-hover-fg -> menu-item-hover-text-color menu-submenu-hover-bg -> menu-item-hover-background-color menu-group-fg -> menu-group-text-color menu-item-separator -> menu-item-divider-color menu-icon-font-size -> menu-item-icon-width menu-icon-margin -> menu-item-icon-margin menu-icon-color -> menu-item-icon-color menu-icon-active-color -> menu-item-icon-active-color Following theme properties were removed: menu-submenu-active-shadow menu-active-font-weight menu-submenu-item-container-padding menu-group-font-weight menu-group-font-size menu-group-padding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
BREAKING CHANGE:
Removed inverse mode.
NbMenuComponent 'autoCollapseValue' property changed to 'autoCollapse'.
Following theme variables were removed:
menu-font-family -> menu-text-font-family
menu-font-size -> menu-text-font-size
menu-font-weight -> menu-text-font-weight
menu-fg -> menu-text-color
menu-bg -> menu-background-color
menu-active-fg -> menu-item-active-text-color
menu-active-bg -> menu-item-active-background-color
menu-submenu-bg -> menu-submenu-background-color
menu-submenu-fg -> menu-submenu-text-color
menu-submenu-active-fg -> menu-submenu-item-active-text-color
menu-submenu-active-bg -> menu-submenu-item-active-background-color
menu-submenu-active-border-color -> menu-submenu-item-active-border-color
menu-submenu-hover-fg -> menu-item-hover-text-color
menu-submenu-hover-bg -> menu-item-hover-background-color
menu-group-fg -> menu-group-text-color
menu-item-separator -> menu-item-divider-color
menu-icon-font-size -> menu-item-icon-width
menu-icon-margin -> menu-item-icon-margin
menu-icon-color -> menu-item-icon-color
menu-icon-active-color -> menu-item-icon-active-color
Following theme properties were removed:
menu-submenu-active-shadow
menu-active-font-weight
menu-submenu-item-container-padding
menu-group-font-weight
menu-group-font-size
menu-group-padding