Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update js themes #1631

Merged
merged 10 commits into from
Jul 1, 2019
Merged

feat: update js themes #1631

merged 10 commits into from
Jul 1, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jun 22, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Includes background and border levels, updated colors and dark js theme.
Closes #1610.

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #1631 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
- Coverage   83.54%   83.41%   -0.14%     
==========================================
  Files         231      232       +1     
  Lines        7562     7563       +1     
  Branches      664      664              
==========================================
- Hits         6318     6309       -9     
- Misses       1051     1061      +10     
  Partials      193      193
Impacted Files Coverage Δ
...mework/theme/services/js-themes/corporate.theme.ts 100% <ø> (ø) ⬆️
...framework/theme/services/js-themes/cosmic.theme.ts 100% <ø> (ø) ⬆️
...ramework/theme/services/js-themes/default.theme.ts 100% <ø> (ø) ⬆️
...c/framework/theme/services/js-themes/dark.theme.ts 100% <100%> (ø)
...ework/theme/services/js-themes-registry.service.ts 88% <100%> (+0.24%) ⬆️
src/framework/theme/public_api.ts 100% <100%> (ø) ⬆️
src/framework/theme/services/color.helper.ts 25% <0%> (-41.67%) ⬇️

@yggg yggg merged commit 4d66419 into master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nebular 4: JS Themes are not updated
3 participants