Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): make options list same width as button #1650

Merged
merged 3 commits into from
Jun 28, 2019
Merged

fix(select): make options list same width as button #1650

merged 3 commits into from
Jun 28, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jun 28, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes case when nb-select itself has padding leading to overlay being disconnected from a button or having width more than a button.

@yggg yggg requested a review from Tibing June 28, 2019 11:42
@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #1650 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1650   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files         231      231           
  Lines        7560     7560           
  Branches      663      663           
=======================================
  Hits         6316     6316           
  Misses       1051     1051           
  Partials      193      193
Impacted Files Coverage Δ
...mework/theme/components/select/select.component.ts 86.74% <100%> (ø) ⬆️

@yggg yggg merged commit 1658ccf into akveo:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants