fix(select): add theme property for open select border #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every appearance has own options list border color settings. And since select should has appearance anyway there is no change `select-options-list-border-color` could be applied.
…elect `select-outline-<status>-adjacent-border-color`, `select-outline-<status>-adjacent-border-style`, `select-outline-<status>-adjacent-border-width` theme variables were unused.
Tibing
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Fixes select in corporate theme. Now both select and options list has same border.
Also removes
select-options-list-border-colorsince it always overwritten byselect-<appearance>-options-list-border-color.And
select-outline-<status>-adjacent-border-color,select-outline-<status>-adjacent-border-style,select-outline-<status>-adjacent-border-widththeme variables were unused. I added appropriate styles for this properties.