Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): expand when menu with children clicked #1750

Merged
merged 3 commits into from
Jul 9, 2019
Merged

fix(sidebar): expand when menu with children clicked #1750

merged 3 commits into from
Jul 9, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jul 9, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@yggg yggg requested a review from nnixaa July 9, 2019 15:09
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #1750 into master will increase coverage by 0.49%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1750      +/-   ##
==========================================
+ Coverage   83.42%   83.91%   +0.49%     
==========================================
  Files         232      232              
  Lines        7564     7567       +3     
  Branches      664      665       +1     
==========================================
+ Hits         6310     6350      +40     
+ Misses       1061     1023      -38     
- Partials      193      194       +1
Impacted Files Coverage Δ
...work/theme/components/sidebar/sidebar.component.ts 54.34% <100%> (+20.27%) ⬆️
.../framework/theme/components/menu/menu.component.ts 76.42% <0%> (+3.25%) ⬆️
...amework/theme/components/sidebar/sidebar.module.ts 100% <0%> (+10%) ⬆️
...mework/theme/components/sidebar/sidebar.service.ts 80% <0%> (+30%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants