Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toastr): dispose no longer used overlay container #1873

Merged
merged 6 commits into from
Oct 10, 2019
Merged

fix(toastr): dispose no longer used overlay container #1873

merged 6 commits into from
Oct 10, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jul 31, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes memory leak when overlay container removed from body (for instance, when nb-layout changed) was just replaced by a new one without disposing previous.

@yggg yggg requested a review from nnixaa July 31, 2019 08:21
@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #1873 into master will increase coverage by <.01%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master    #1873      +/-   ##
==========================================
+ Coverage   84.18%   84.19%   +<.01%     
==========================================
  Files         235      235              
  Lines        7899     7902       +3     
  Branches      691      692       +1     
==========================================
+ Hits         6650     6653       +3     
  Misses       1046     1046              
  Partials      203      203
Impacted Files Coverage Δ
...ramework/theme/components/toastr/toastr.service.ts 90.67% <100%> (+0.16%) ⬆️
...me/components/toastr/toastr-container.component.ts 66.66% <40%> (+1.28%) ⬆️

@yggg yggg merged commit 4114ad1 into akveo:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants