-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: accept icon config in components which use nb-icon #1935
Merged
yggg
merged 11 commits into
akveo:master
from
yggg:feat/icon-config-options-for-components-with-icons
Aug 29, 2019
Merged
feat: accept icon config in components which use nb-icon #1935
yggg
merged 11 commits into
akveo:master
from
yggg:feat/icon-config-options-for-components-with-icons
Aug 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1935 +/- ##
==========================================
- Coverage 84.14% 84.08% -0.07%
==========================================
Files 234 234
Lines 7703 7723 +20
Branches 675 679 +4
==========================================
+ Hits 6482 6494 +12
- Misses 1023 1031 +8
Partials 198 198
|
nnixaa
approved these changes
Aug 28, 2019
4 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #1851
Closes #1323