Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popover, tooltip): add shown state api #1998

Merged
merged 20 commits into from
Oct 7, 2019
Merged

feat(popover, tooltip): add shown state api #1998

merged 20 commits into from
Oct 7, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Oct 4, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Adds nbPopoverShowStateChange output to the popover directive.
Also adds ability to use popover as a template variable:

<button nbPopover="..." #popover="nbPopover">...</button>

Is shown: {{ popover.isShown }}

Private popover directive properties changed to protected to simplify extension.

Add input for popover css class.

All above applies to tooltip as well.

@yggg yggg requested a review from lugovsky October 4, 2019 15:13
@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #1998 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #1998     +/-   ##
=========================================
+ Coverage   84.13%   84.23%   +0.1%     
=========================================
  Files         235      235             
  Lines        7835     7887     +52     
  Branches      684      689      +5     
=========================================
+ Hits         6592     6644     +52     
  Misses       1042     1042             
  Partials      201      201
Impacted Files Coverage Δ
...nts/cdk/overlay/dynamic/dynamic-overlay-handler.ts 100% <100%> (ø) ⬆️
...work/theme/components/tooltip/tooltip.directive.ts 100% <100%> (ø) ⬆️
...work/theme/components/popover/popover.directive.ts 100% <100%> (ø) ⬆️
.../components/cdk/overlay/dynamic/dynamic-overlay.ts 99.11% <100%> (+0.13%) ⬆️

@yggg yggg changed the title feat(popover): add shown state api feat(popover, tooltip): add shown state api Oct 7, 2019
@yggg yggg requested review from nnixaa and removed request for lugovsky October 7, 2019 11:09
@yggg yggg merged commit 6dbce1d into akveo:master Oct 7, 2019
@yggg yggg deleted the feat/popover-open-state branch October 7, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant