-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(popover, tooltip): add shown state api #1998
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to extend
Codecov Report
@@ Coverage Diff @@
## master #1998 +/- ##
=========================================
+ Coverage 84.13% 84.23% +0.1%
=========================================
Files 235 235
Lines 7835 7887 +52
Branches 684 689 +5
=========================================
+ Hits 6592 6644 +52
Misses 1042 1042
Partials 201 201
|
yggg
changed the title
feat(popover): add shown state api
feat(popover, tooltip): add shown state api
Oct 7, 2019
Calling dispose marks service as dead which in turn completes streams, etc. so overlay won't fully work when we call show. To update component we just need to recreate overlay ref.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Adds
nbPopoverShowStateChange
output to the popover directive.Also adds ability to use popover as a template variable:
Private popover directive properties changed to protected to simplify extension.
Add input for popover css class.
All above applies to tooltip as well.