Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): check trigger strategy is defined before destroying #2011

Merged
merged 4 commits into from
Oct 10, 2019

Conversation

CandidCodingCanary
Copy link
Contributor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Prevents the DatePickerComponent from crashing if it is destroyed shortly after its creation. View this issue for a more detailed description: #2007.

This error occurs without the null check:
Capture2

Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CandidCodingCanary! 👍

@yggg yggg changed the title Add a Null Check for triggerStrategy in DatePickerComponent.ngOnDestroy fix(datepicker): check trigger strategy is defined before destroying Oct 10, 2019
@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #2011 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2011      +/-   ##
==========================================
+ Coverage   84.19%   84.19%   +<.01%     
==========================================
  Files         235      235              
  Lines        7902     7903       +1     
  Branches      692      693       +1     
==========================================
+ Hits         6653     6654       +1     
  Misses       1046     1046              
  Partials      203      203
Impacted Files Coverage Δ
...heme/components/datepicker/datepicker.component.ts 90.15% <100%> (+0.05%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants