Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom css class on overlays #2067

Merged
merged 4 commits into from
Nov 14, 2019
Merged

feat: add custom css class on overlays #2067

merged 4 commits into from
Nov 14, 2019

Conversation

FourthOf5
Copy link
Collaborator

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1148

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #2067 into master will increase coverage by 0.48%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #2067      +/-   ##
==========================================
+ Coverage   84.08%   84.57%   +0.48%     
==========================================
  Files         235      235              
  Lines        8031     8038       +7     
  Branches      705      706       +1     
==========================================
+ Hits         6753     6798      +45     
+ Misses       1068     1020      -48     
- Partials      210      220      +10
Impacted Files Coverage Δ
...ramework/theme/components/dialog/dialog.service.ts 89.23% <ø> (ø) ⬆️
...framework/theme/components/dialog/dialog-config.ts 100% <100%> (ø) ⬆️
.../components/context-menu/context-menu.directive.ts 90.19% <100%> (+0.19%) ⬆️
...framework/theme/components/toastr/toastr-config.ts 84.61% <100%> (+0.61%) ⬆️
...amework/theme/components/toastr/toast.component.ts 79.16% <83.33%> (+33.71%) ⬆️
...k/theme/components/cdk/overlay/overlay-position.ts 95.68% <0%> (+1.72%) ⬆️
...ramework/theme/components/toastr/toastr.service.ts 97.5% <0%> (+7.5%) ⬆️
...rk/theme/components/cdk/overlay/position-helper.ts 47.54% <0%> (+11.47%) ⬆️
...me/components/toastr/toastr-container.component.ts 88.88% <0%> (+22.22%) ⬆️

Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yggg yggg merged commit 147ec2e into akveo:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opportunity to add custom css class on overlays
2 participants