fix(nbIsGranted): prevent subscription memory leak #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to prevent a memory leak in NbIsGrantedDirective, properly unsubscribe from the NbAccessChecker isGranted subscription using a Subject and takeUntil operator.
yggg
approved these changes
Nov 20, 2019
|
@drumonii That would be great. I've added one more thing to do in the scope of #1059 (see the last #1059 (comment)). If you have any comments or suggestion, let's move further discussion there. |
yggg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent a memory leak in
NbIsGrantedDirective, properly unsubscribe from theNbAccessChecker'sisGrantedsubscription using aSubjectandtakeUntiloperator.Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Resolves #1385