Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ARIA-role on the Toggle Component #2096

Closed
1 of 2 tasks
trickpatty opened this issue Nov 26, 2019 · 0 comments · Fixed by #2097
Closed
1 of 2 tasks

Fix the ARIA-role on the Toggle Component #2096

trickpatty opened this issue Nov 26, 2019 · 0 comments · Fixed by #2097

Comments

@trickpatty
Copy link

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Current behavior:
The toggle component uses an aria-role of "switcher".

Expected behavior:
The correct role should instead be "switch". See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques for details.

Steps to reproduce:

Related code:
See toggle.component.ts

<input type="checkbox"
             class="native-input visually-hidden"
             role="switch"
             [attr.aria-checked]="checked"
             [disabled]="disabled"
             [checked]="checked"
             (change)="updateValue($event)"
             (blur)="onTouched()"
             (click)="onInputClick($event)">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant