Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid to declare and export NbTable component #2126

Merged
merged 5 commits into from
Mar 13, 2020

Conversation

adwd
Copy link
Contributor

@adwd adwd commented Dec 9, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

NbTable is only used as base class of NbTreeGridComponent but is is declared and exported. Because of this, cdk-table cannot be used.
This PR removes NbTable from declare/export array to fix it.

<!-- in app using Nebular -->
<table cdk-table [dataSource]="dataSource">
  ...
</table>
More than one component matched on this element.
Make sure that only one component's selector can match a given element.
Conflicting components: NbTable,CdkTable

@yggg yggg added this to the 5.0.0 milestone Dec 30, 2019
@yggg yggg changed the title avoid to declare/export NbTable component fix: avoid to declare and export NbTable component Mar 13, 2020
yggg
yggg previously approved these changes Mar 13, 2020
yggg and others added 2 commits March 13, 2020 19:15
Fixes:
More than one component matched on this element.
Make sure that only one component's selector can match a given element.
Conflicting components: NbTable,CdkTable
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #2126 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2126   +/-   ##
=======================================
  Coverage   81.53%   81.53%           
=======================================
  Files         244      244           
  Lines        7377     7377           
  Branches      773      773           
=======================================
  Hits         6015     6015           
  Misses       1135     1135           
  Partials      227      227           
Impacted Files Coverage Δ
...amework/theme/components/cdk/table/table.module.ts 100.00% <ø> (ø)

@yggg
Copy link
Contributor

yggg commented Mar 13, 2020

@adwd Thanks for the PR. Unfortunately, we can't keep the component decorator without adding it to the module. Instead, I changed NbTable component selector to a different one. It'll fix the issue as well.

@yggg yggg merged commit dbf5192 into akveo:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants