Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): access view child property after view init #2249

Merged
merged 3 commits into from
Mar 5, 2020

Conversation

eugene-sinitsyn
Copy link
Contributor

Closes #2195

@yggg yggg removed their assignment Mar 3, 2020
@yggg yggg self-requested a review March 3, 2020 14:46
yggg
yggg previously approved these changes Mar 5, 2020
@yggg yggg changed the title Fix console error related to scrolling in layout component fix(layout): access view child property after view init Mar 5, 2020
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #2249 into master will increase coverage by 0.04%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #2249      +/-   ##
==========================================
+ Coverage   81.62%   81.66%   +0.04%     
==========================================
  Files         244      244              
  Lines        7329     7329              
  Branches      771      771              
==========================================
+ Hits         5982     5985       +3     
+ Misses       1120     1117       -3     
  Partials      227      227
Impacted Files Coverage Δ
...mework/theme/components/layout/layout.component.ts 72.67% <71.42%> (ø) ⬆️
...rc/framework/theme/components/menu/menu.service.ts 87.59% <0%> (+0.72%) ⬆️
.../framework/theme/components/menu/menu.component.ts 77.67% <0%> (+1.78%) ⬆️

@yggg yggg merged commit 5bb21a7 into master Mar 5, 2020
@yggg yggg deleted the fix/layout-scroll-error branch March 5, 2020 13:17
@yggg yggg mentioned this pull request Mar 16, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The viewchild scrollableContainerRef is undefined on Angular 9, Ivy
2 participants