-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to Angular 10 #2464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync method was removed.
tslint started to complain about whitespace before the `?`. Specifying type for field fixes this error.
typeof-compare is deprecated. Starting from TypeScript 2.2 the compiler includes this check which makes this rule redundant.
Looks like we have tests which rely on execution order, e.g. menu.spec.ts. Random execution causes random tests to fail. Disabling random order fixes this. #2465
Fixes incompatibility errors in schematics tests
Codecov Report
@@ Coverage Diff @@
## master #2464 +/- ##
==========================================
- Coverage 81.44% 80.46% -0.98%
==========================================
Files 244 244
Lines 7399 7172 -227
Branches 778 785 +7
==========================================
- Hits 6026 5771 -255
- Misses 1140 1168 +28
Partials 233 233
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync method was removed.### Please read and mark the following check list before creating a pull request:
Short description of what this resolves: