Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): add ellipsis on selection view #2809

Merged
merged 3 commits into from
Nov 9, 2021

Conversation

chirichok98
Copy link
Contributor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes #2608

Fix replaces overflowed text with ellipsis.

@chirichok98 chirichok98 changed the title fix (select): fixed long text with ellip fix(select): change long text with ellipsis before icon Aug 3, 2021
@chirichok98 chirichok98 changed the title fix(select): change long text with ellipsis before icon fix(select): add ellipsis before icon for long text Aug 3, 2021
Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you manage to reproduce the issue? I can't see it happening on the latest version.

@chirichok98
Copy link
Contributor Author

It can be reproduced! Main goal is to set a lot of items in select to fit width of the page (not width of the select itself as it will be extended till the width of the page) and then text overflows icon.

@yggg yggg added this to the 9.0.0 milestone Aug 6, 2021
@yggg
Copy link
Contributor

yggg commented Aug 6, 2021

Postponing to 9.0.0 as probably someone relying on previous elements structure.

@yggg yggg changed the title fix(select): add ellipsis before icon for long text fix(select): add ellipsis on selection view Nov 9, 2021
@yggg yggg merged commit 9b525f4 into akveo:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nb-select when multiple overlapping nb-icon
2 participants