feat(tabset): ability to provide template as tab label #2829

evtkhvch · 2021-08-16T12:27:23Z

Please read and mark the following check list before creating a pull request:

I read and followed the CONTRIBUTING.md guide.
I read and followed the New Feature Checklist guide.

Short description of what this resolves:

Closes #1915

add ability to provide a template as a tab title via <ng-template nbTabTitle>
add example to the docs

src/framework/theme/components/tabset/tab-label.ts

src/framework/theme/components/tabset/tab-content.ts

…eat-tab-title # Conflicts: # src/framework/theme/components/tabset/tabset.component.ts # src/framework/theme/components/tabset/tabset.module.ts

src/framework/theme/components/tabset/tabset.component.ts

src/framework/theme/components/tabset/tab-label.ts

…eat-tab-title

src/framework/theme/components/tabset/tabset.component.ts

src/framework/theme/components/tabset/tab-label.ts

yggg

And let's add an example to the docs

evtkhvch added 7 commits August 13, 2021 16:03

fix(tabset): lazy load

6ddc5c8

ref(tabset): extract view logic

5a99e0a

ref(tabset): turn activeValue into active

3eee78f

ref(tabset): made init property deprecated

2a32b46

chore(NbTabComponent): init property description

9aac907

style(tabset): add new lines

6579461

feat(tabset): template tab label

4c34d3b

evtkhvch marked this pull request as ready for review August 16, 2021 12:34

evtkhvch changed the title ~~feat(tabset): template tab label~~ feat(tabset): template as tab label Aug 16, 2021

yggg mentioned this pull request Sep 16, 2021

fix(tabset): lazy loading #2827

Merged

2 tasks

yggg suggested changes Sep 16, 2021

View reviewed changes

src/framework/theme/components/tabset/tab-label.ts Outdated Show resolved Hide resolved

src/framework/theme/components/tabset/tab-label.ts Outdated Show resolved Hide resolved

src/framework/theme/components/tabset/tab-content.ts Outdated Show resolved Hide resolved

evtkhvch and others added 8 commits September 20, 2021 15:08

fix(tabset): remove extra changes

3d353e5

Merge remote-tracking branch 'origin/1915-feat-tab-title' into 1915-f…

d1d1566

…eat-tab-title # Conflicts: # src/framework/theme/components/tabset/tabset.component.ts # src/framework/theme/components/tabset/tabset.module.ts

fix(tabset): remove tab content

a8f7690

fix(tabset): remove set method

272e0a9

fix(tabset): remove extra selector for tab label directive

8be1b60

fix(tabset): add NbPortalModule to cdk

2e0517d

fix(tabset): add NbPortal to cdk

36774d4

Merge branch 'master' into 1915-feat-tab-title

21fc191

yggg suggested changes Nov 8, 2021

View reviewed changes

src/framework/theme/components/tabset/tabset.component.ts Outdated Show resolved Hide resolved

src/framework/theme/components/tabset/tabset.component.ts Outdated Show resolved Hide resolved

src/framework/theme/components/tabset/tab-label.ts Outdated Show resolved Hide resolved

evtkhvch and others added 7 commits November 8, 2021 17:48

fix(tabset): remove nbPortalModule

949e806

fix(tabset): remove NB_TAB_LABEL injection token

cf79be4

fix(tabset): use ngTemplateOutlet instead portal directive

a6e6356

Merge branch 'master' into 1915-feat-tab-title

b0f76d1

fix(tabset): read directive as a template

0574bdf

Merge remote-tracking branch 'origin/1915-feat-tab-title' into 1915-f…

7126e4e

…eat-tab-title

fix(public-api): add tab label directive

a0ef68f

yggg suggested changes Nov 8, 2021

View reviewed changes

evtkhvch added 4 commits November 9, 2021 11:42

fix(tabset): remove comments

341f273

style(tabset):rename content variable

1d8ba2e

style(tabset):rename tab label directive

a9a418b

docs: add tab title template to examples

f2828d0

evtkhvch requested a review from yggg November 9, 2021 12:49

yggg added this to the 9.0.0 milestone Nov 12, 2021

Merge branch 'master' into 1915-feat-tab-title

b00645a

yggg changed the title ~~feat(tabset): template as tab label~~ feat(tabset): ability to provide template as tab label Nov 15, 2021

yggg added 6 commits November 15, 2021 18:43

Merge branch 'master' into 1915-feat-tab-title

df61b0b

refactor(tab title): correctly name file

ee85632

docs(tab title): simplify example

25df7af

refactor(tab title): rename title template property

18f27dc

fix(tab title): update export path

896b100

docs(tab title): update example file name

7878195

yggg previously approved these changes Nov 15, 2021

View reviewed changes

docs(tab title): correct template title

9e75e5e

yggg dismissed their stale review via 9e75e5e November 15, 2021 16:19

yggg previously approved these changes Nov 15, 2021

View reviewed changes

docs(tab title): correct template title example path

8458d77

yggg dismissed their stale review via 8458d77 November 15, 2021 16:32

yggg approved these changes Nov 16, 2021

View reviewed changes

yggg merged commit d56a492 into akveo:master Nov 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tabset): ability to provide template as tab label #2829

feat(tabset): ability to provide template as tab label #2829

evtkhvch commented Aug 16, 2021 •

edited

Loading

yggg left a comment

feat(tabset): ability to provide template as tab label #2829

feat(tabset): ability to provide template as tab label #2829

Conversation

evtkhvch commented Aug 16, 2021 • edited Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

yggg left a comment

Choose a reason for hiding this comment

evtkhvch commented Aug 16, 2021 •

edited

Loading