Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tooltip, popover): add disabled property #2841

Merged
merged 13 commits into from
Nov 8, 2021
Merged

feat(tooltip, popover): add disabled property #2841

merged 13 commits into from
Nov 8, 2021

Conversation

evtkhvch
Copy link
Contributor

@evtkhvch evtkhvch commented Aug 23, 2021 •
edited by yggg
Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2324

add nbTooltipDisabled property to NbTooltipDirective

  • nbTooltipDisabled equals to trigger = NbTrigger.NOOP
  • hide overlay when nbTooltipDisabled set to true

@evtkhvch evtkhvch marked this pull request as ready for review August 23, 2021 17:05
yggg
yggg suggested changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move disabled logic into NbDynamicOverlayHandler

src/framework/theme/components/tooltip/tooltip.directive.ts Outdated Show resolved Hide resolved
yggg
yggg previously approved these changes Nov 8, 2021
View reviewed changes
@yggg yggg changed the title feat(tooltip): disable the display of the tooltip feat(tooltip, popover): add disabled property Nov 8, 2021
@yggg yggg merged commit b7fe861 into akveo:master Nov 8, 2021
@yggg yggg mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yggg yggg yggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip disable feature in directive like matTooltip
2 participants
@evtkhvch @yggg