Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): prevent expression changed error on icon button #2846

Merged
merged 6 commits into from
Nov 8, 2021

Conversation

evtkhvch
Copy link
Contributor

@evtkhvch evtkhvch commented Aug 25, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2363

  • fix NG0100 error in NbButton.iconRight

Error description. Error appears in the following case:

  1. You use nbSpinner directive
  2. <button> content contains <nb-icon> only
  3. loading state changes

Example:

<button [nbSpinner]="loading" nbButton>
  <nb-icon icon="star"></nb-icon>
</button>

Problem: NbButton.iconRight has been changed after change detection has completed

@evtkhvch evtkhvch marked this pull request as ready for review August 25, 2021 15:27
@yggg yggg changed the title fix(base-button): NG0100 Expression has changed after it was checked fix(button): prevent expression changed error on icon button Nov 8, 2021
@yggg yggg merged commit baee608 into akveo:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants