Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): don't style user icons in checkbox #2857

Merged
merged 5 commits into from
Sep 14, 2021

Conversation

katebatura
Copy link
Contributor

@katebatura katebatura commented Sep 6, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2270

Fixed nb-icon styles in NbCheckboxComponent.

@katebatura katebatura requested a review from yggg September 6, 2021 07:21
@katebatura katebatura changed the title fix(nb-checkbox): nb-icon styles fix(nb-checkbox): don't style user icons in checkbox Sep 14, 2021
@@ -19,6 +19,14 @@
border-width: nb-theme(checkbox-border-width);
border-radius: nb-theme(checkbox-border-radius);
position: relative;

nb-icon {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove nesting

@yggg yggg changed the title fix(nb-checkbox): don't style user icons in checkbox fix(checkbox): don't style user icons in checkbox Sep 14, 2021
@yggg yggg merged commit a94a867 into akveo:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

icons inside NbCheckboxComponent get (unwanted) width and style
2 participants