-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(window): add component instance property to window ref #2858
Merged
yggg
merged 4 commits into
akveo:master
from
katebatura:feat/2367-nb-window-window_content_instance
Sep 15, 2021
Merged
feat(window): add component instance property to window ref #2858
yggg
merged 4 commits into
akveo:master
from
katebatura:feat/2367-nb-window-window_content_instance
Sep 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yggg
suggested changes
Sep 14, 2021
componentRef: ComponentRef<NbWindowComponent>; | ||
windowContentInstance: T; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
componentInstance
katebatura
changed the title
feat(nb-window): windowContent instance
feat(window): instance of the component opened into winow
Sep 14, 2021
katebatura
changed the title
feat(window): instance of the component opened into winow
feat(window): instance of the component opened into window
Sep 14, 2021
yggg
suggested changes
Sep 14, 2021
@@ -7,9 +7,11 @@ import { NbWindowConfig, NbWindowState, NbWindowStateChange } from './window.opt | |||
* The `NbWindowRef` helps to manipulate window after it was created. | |||
* The window can be dismissed by using `close` method of the windowRef. | |||
* You can access rendered component as `componentRef` property of the windowRef. | |||
* Property `windowContentInstance` contains the instance of the component opened into the window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* Property `windowContentInstance` contains the instance of the component opened into the window. | |
* Property `contentInstance` contains the instance of the component opened in the window. |
yggg
approved these changes
Sep 15, 2021
yggg
changed the title
feat(window): instance of the component opened into window
feat(window): add component instance property to window ref
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #2367
Added
componentInstance
property toNbWindowRef
contains the instance of the component opened into he window.How to use: