Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(focus trigger strategy): detect click out via activeElement #2865

Merged
merged 3 commits into from
Sep 14, 2021

Conversation

sashaqred
Copy link
Member

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Click event is fired after focus in/out, so check of event target could be not document.activeElement

@sashaqred sashaqred requested a review from yggg September 10, 2021 13:36
@sashaqred sashaqred self-assigned this Sep 10, 2021
@yggg yggg changed the title fix: fix clickOut event on focus strategy fix(focus trigger strategy): detect click out by checking activeElement Sep 14, 2021
@yggg yggg changed the title fix(focus trigger strategy): detect click out by checking activeElement fix(focus trigger strategy): detect click out by activeElement Sep 14, 2021
@yggg yggg changed the title fix(focus trigger strategy): detect click out by activeElement fix(focus trigger strategy): detect click out via activeElement Sep 14, 2021
@yggg yggg merged commit 1f8e0cb into master Sep 14, 2021
@yggg yggg deleted the fix/fix-clickOut-event-on-focus-strategy branch September 14, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants