Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(window): window may return result #2869

Merged
merged 10 commits into from
Nov 30, 2021

Conversation

katebatura
Copy link
Contributor

@katebatura katebatura commented Sep 12, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2696

The window may return result through NbWindowRef. Calling component can receive this result with onClose stream of NbWindowRef.

How to use:

this.windowService.open(SomeComponent, {title: `Window`}).onClose.subscribe(result => {
    //do something...
});

Example is here: https://akveo.github.io/nebular/docs/components/window/overview#nbwindowservice

@katebatura katebatura self-assigned this Sep 12, 2021
@katebatura katebatura requested a review from yggg September 12, 2021 17:44
@katebatura katebatura changed the title feat(nb-window): window may return result feat(window): window may return result Sep 17, 2021
@yggg yggg added this to the 9.0.0 milestone Nov 12, 2021
billnice250
billnice250 previously approved these changes Nov 12, 2021
@yggg yggg merged commit 95247a4 into akveo:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbWindow - passing data when closing
3 participants