Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icon): add support for ligature icons #2951

Merged
merged 3 commits into from
Nov 25, 2021
Merged

feat(icon): add support for ligature icons #2951

merged 3 commits into from
Nov 25, 2021

Conversation

vladsklov
Copy link

@vladsklov vladsklov commented Nov 22, 2021 •
edited by yggg
Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Adds support for ligature based icons

Closes #2554

@vladsklov vladsklov requested a review from yggg November 22, 2021 11:26
@vladsklov vladsklov self-assigned this Nov 22, 2021
@vladsklov vladsklov changed the title fix(icon): ligature based icon are not supported feat(icon): ligature based icon are not supported Nov 22, 2021
@yggg yggg added this to the 9.0.0 milestone Nov 22, 2021
@yggg yggg changed the title feat(icon): ligature based icon are not supported feat(icon): add support for ligature icons Nov 22, 2021
yggg
yggg suggested changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add optional ligature field to the NbFontIconPackParams interface.

src/framework/theme/components/icon/icon-libraries.ts Outdated Show resolved Hide resolved
src/framework/theme/components/icon/icon-libraries.ts Outdated Show resolved Hide resolved
src/framework/theme/components/icon/icon-libraries.ts Outdated Show resolved Hide resolved
src/framework/theme/components/icon/icon-libraries.ts Outdated Show resolved Hide resolved
@vladsklov vladsklov force-pushed the fix/2554-nb-icon_ligature_based_icon_are_not_supported branch from 53e1cb9 to 5e37a9e Compare November 25, 2021 09:18
@yggg yggg merged commit b89339d into akveo:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yggg yggg yggg approved these changes

Assignees

@vladsklov vladsklov

Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Ligature based icons (i.e. Material icons) are not supported
2 participants
@vladsklov @yggg