feat(window) #713
Merged
feat(window) #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will allow users to extend nebular classes and override something if needed.
nnixaa
requested changes
Sep 14, 2018
| </svg> | ||
| `, | ||
| styleUrls: ['./window-icon.component.scss'], | ||
| host: { |
There was a problem hiding this comment.
we don't use host in Nebular, only @HostBinding
| `, | ||
| styleUrls: ['./window-icon.component.scss'], | ||
| host: { | ||
| 'aria-label': 'expand', |
There was a problem hiding this comment.
we don't use host in Nebular, only @HostBinding
| `, | ||
| styleUrls: ['./window-icon.component.scss'], | ||
| host: { | ||
| 'aria-label': 'close', |
There was a problem hiding this comment.
we don't use host in Nebular, only @HostBinding
| `, | ||
| styleUrls: ['./window-icon.component.scss'], | ||
| host: { | ||
| 'aria-label': 'minimize', |
There was a problem hiding this comment.
we don't use host in Nebular, only @HostBinding
| export class NbWindowRef { | ||
| componentRef: ComponentRef<NbWindowComponent>; | ||
|
|
||
| protected _prevState: NbWindowState; |
Tibing
requested changes
Sep 14, 2018
| @@ -47,6 +50,13 @@ export class NbPlatform extends Platform { | |||
| export class NbOverlayPositionBuilder extends OverlayPositionBuilder { | |||
| } | |||
|
|
|||
| @Injectable() | |||
| export class NbBlockScrollStrategy extends BlockScrollStrategy { | |||
| constructor(ruler: ViewportRuler, @Inject(NB_DOCUMENT) document) { | |||
There was a problem hiding this comment.
Lets provide NbViewportRulerAdapter here.
| /** | ||
| * Size of window. Large by default. | ||
| */ | ||
| size: NbWindowSize = NbWindowSize.LARGE; |
There was a problem hiding this comment.
I think the user has to provide two sizes: one for the full-screen state and one for the max. Otherwise, as I understand correctly, in the maximized state window will be full-screen and will occupy the same amount of space but in the right bottom corner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #669