Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performing an edit might result in an error when the data source is being updated by an Obervable #279

Closed
Ezeon opened this issue Apr 3, 2017 · 1 comment
Closed

Performing an edit might result in an error when the data source is being updated by an Obervable #279

Ezeon opened this issue Apr 3, 2017 · 1 comment

Comments

@Ezeon
Copy link
Contributor

Ezeon commented Apr 3, 2017

Performing an edit might sometimes result in an error when the data source is being updated by an Obervable.

Please see the attach error log.

smart-table-edit-error.txt
@Ezeon Ezeon mentioned this issue Apr 3, 2017
Merged
@Ezeon
Copy link
Contributor Author

Ezeon commented Apr 3, 2017 •
edited
Loading

This seems to be an issue when the smart table is used together with Observables. I believe the best solution would be to allow for the smart table not to perform the edit operation on the data source. The updates can in this case be done by the Observable instead.

I've created a pull request to add this functionality.

Integration with rxjs and Observables now seems to be working correctly after this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ezeon