Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart table dependency ng2-completer 2.0.8 imports HttpClientModule #939

Open
1 of 2 tasks
danshou opened this issue Jan 17, 2019 · 1 comment
Open
1 of 2 tasks

Comments

@danshou
Copy link

danshou commented Jan 17, 2019

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Current behavior:

Interceptors doesn't catch httpClient calls from lazy modules.

Expected behavior:

Interceptor should catch any httpClient call.

Steps to reproduce:

nebular 3.1.0, ng2-smart-table 1.3.5 and ng2-completer 2.0.8

Related code:

insert short code snippets here

Other information:

npm, node, OS, Browser

npm: 10.15.0
OS: Ubuntu 18
Browser: Chrome

Angular, Nebular

angular: 7.2.0
nebular: 3.1.0

There is a known problem with HttpClientModule, it can't be imported multiple times. So, no other package should import it (was removed from nebular too akveo/nebular#631).

But, not long ago, smart table started to use ng2-completer 2.0.8 but this library calls HttpClientModule to work and overrides the HttpClient calls. And some of our calls weren't catched by the interceptors.

This was acknowledged to ng2-completer community so they removed it in version 3.0.0-beta.2 (oferh/ng2-completer#393). And now everything works fine.

Should version 3.0.0-beta.2 be mandatory in the package.json? (this solves the problem)

Thanks in advance.

@nnixaa nnixaa transferred this issue from akveo/nebular Jan 28, 2019
@6matko
Copy link

6matko commented Feb 22, 2019

I have the same issue except I use Nebular version 3.0.0.
Updating ng2-completer to version 3.0.0-beta.2 helped solve this issue, thanks to danshou.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants