Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Nebular to 4.1.2 #5451

Merged
merged 9 commits into from
Jul 15, 2019
Merged

feat: update Nebular to 4.1.2 #5451

merged 9 commits into from
Jul 15, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jul 12, 2019

Please read and mark the following check list before creating a pull request (check one with "x"):

Short description of what this resolves:

Closes #2162, #2163

@yggg yggg requested a review from nnixaa July 12, 2019 15:39
package.json Outdated
"@nebular/security": "4.1.0",
"@nebular/theme": "4.1.0",
"@nebular/auth": "4.1.2",
"@nebular/bootstrap": "4.1.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we removed almost completely, do we need it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You right, removed in e7f91b8

@yggg yggg requested a review from nnixaa July 15, 2019 11:02
@yggg yggg merged commit a2e93f9 into akveo:master Jul 15, 2019
@yggg yggg deleted the feat/update-nebular-to-4-1-2 branch July 15, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dark theme has issues with charts on demo
2 participants